tools/perf/measurements/smoothness.py - Issue 208643007: Add cleanup for measurements that use tracing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/smoothness.py

Issue 208643007: Add cleanup for measurements that use tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/measurements/repaint_unittest.py ('k') | tools/perf/measurements/smoothness_controller.py » ('j') | tools/perf/measurements/smoothness_controller.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from metrics import power	5 from metrics import power

6 from measurements import smoothness_controller	6 from measurements import smoothness_controller

7 from telemetry.page import page_measurement	7 from telemetry.page import page_measurement

8	8

9	9

10 class Smoothness(page_measurement.PageMeasurement):	10 class Smoothness(page_measurement.PageMeasurement):

(...skipping 15 matching lines...) Expand all Loading...
26 def DidRunAction(self, page, tab, action):	26 def DidRunAction(self, page, tab, action):

27 self._smoothness_controller.AddActionToIncludeInMetric(action)	27 self._smoothness_controller.AddActionToIncludeInMetric(action)

28	28

29 def DidRunActions(self, page, tab):	29 def DidRunActions(self, page, tab):

30 self._power_metric.Stop(page, tab)	30 self._power_metric.Stop(page, tab)

31 self._smoothness_controller.Stop(tab)	31 self._smoothness_controller.Stop(tab)

32	32

33 def MeasurePage(self, page, tab, results):	33 def MeasurePage(self, page, tab, results):

34 self._power_metric.AddResults(tab, results)	34 self._power_metric.AddResults(tab, results)

35 self._smoothness_controller.AddResults(tab, results)	35 self._smoothness_controller.AddResults(tab, results)

	36

	37 def CleanUpAfterPage(self, _, tab):

	38 self._smoothness_controller.CleanUp(tab)

OLD	NEW