UI adjustments for the HIDE button in the screen share notification window.

chrome/browser/ui/views/screen_capture_notification_ui_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/screen_capture_notification_ui.h"
 
 #include "ash/shell.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/ui/views/chrome_views_export.h"
 #include "grit/generated_resources.h"
@@ skipping 11 matching lines @@
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/core/shadow_types.h"
 
 namespace {
 
 const int kMinimumWidth = 460;
 const int kMaximumWidth = 1000;
 const int kHorizontalMargin = 10;
-const int kPadding = 5;
-const int kPaddingLeft = 10;
+const int kPaddingVertical = 5;
+const int kPaddingHorizontal = 10;
+const SkColor kHideLinkColor = SkColorSetRGB(0x55, 0x95, 0xFE);

[msw, 2014/03/25 00:01:58]

It's wrong to use a hard-coded color over a themed color (in this case
ui::NativeTheme::kColorId_DialogBackground). What does this look like on a
high-contrast-black windows theme? I'll ping the bug and ask why this color
makes more sense than the conventional/themed link color.

 
 namespace {
 
 // A ClientView that overrides NonClientHitTest() so that the whole window area
 // acts as a window caption, except a rect specified using SetClientRect().
 // ScreenCaptureNotificationUIViews uses this class to make the notification bar
 // draggable.
 class NotificationBarClientView : public views::ClientView {
  public:
   NotificationBarClientView(views::Widget* widget, views::View* view)
@@ skipping 99 matching lines @@
   base::string16 stop_text =
       l10n_util::GetStringUTF16(IDS_MEDIA_SCREEN_CAPTURE_NOTIFICATION_STOP);
   stop_button_ = new views::BlueButton(this, stop_text);
   AddChildView(stop_button_);
 
   // TODO(jiayl): IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON is used for the need to
   // merge to M34. Change it to a new IDS_ after the merge.
   hide_link_ = new views::Link(
       l10n_util::GetStringUTF16(IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON));
   hide_link_->set_listener(this);
+  hide_link_->SetUnderline(false);
+  hide_link_->SetEnabledColor(kHideLinkColor);
   AddChildView(hide_link_);
 }
 
 ScreenCaptureNotificationUIViews::~ScreenCaptureNotificationUIViews() {
   stop_callback_.Reset();
   delete GetWidget();
 }
 
 void ScreenCaptureNotificationUIViews::OnStarted(
     const base::Closure& stop_callback) {
@@ skipping 98 matching lines @@
     views::Widget* widget) {
   DCHECK(!client_view_);
   client_view_ = new NotificationBarClientView(widget, this);
   return client_view_;
 }
 
 views::NonClientFrameView*
 ScreenCaptureNotificationUIViews::CreateNonClientFrameView(
     views::Widget* widget) {
   views::BubbleFrameView* frame = new views::BubbleFrameView(
-      gfx::Insets(kPadding, kPaddingLeft, kPadding, kPadding));
+      gfx::Insets(kPaddingVertical,
+                  kPaddingHorizontal,
+                  kPaddingVertical,
+                  kPaddingHorizontal));
   SkColor color = widget->GetNativeTheme()->GetSystemColor(
       ui::NativeTheme::kColorId_DialogBackground);
   frame->SetBubbleBorder(scoped_ptr<views::BubbleBorder>(
       new views::BubbleBorder(views::BubbleBorder::NONE,
                               views::BubbleBorder::SMALL_SHADOW,
                               color)));
   return frame;
 }
 
 base::string16 ScreenCaptureNotificationUIViews::GetWindowTitle() const {
@@ skipping 33 matching lines @@
   }
 }
 
 }  // namespace
 
 scoped_ptr<ScreenCaptureNotificationUI> ScreenCaptureNotificationUI::Create(
     const base::string16& text) {
   return scoped_ptr<ScreenCaptureNotificationUI>(
       new ScreenCaptureNotificationUIViews(text));
 }