Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 208643002: CompositedLayerMapping should use dirty bits for bounds update (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink, esprehn, Ian Vollick
Visibility:
Public.

Description

CompositedLayerMapping should use dirty bits for bounds update This CL teaches CompositedLayerMapping::updateCompositedBounds about the m_needToUpdateGeometry dirty bit. Now we only update the composited bounds if they could have possibly changed. This CL saves 14% of the compositing update in Polymer's calculator sample app. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-21 17:31:26 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-21 17:40:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/208643002/1
6 years, 9 months ago (2014-03-21 17:41:01 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 17:43:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-21 17:43:34 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-21 18:16:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/208643002/1
6 years, 9 months ago (2014-03-21 18:16:47 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 19:22:10 UTC) #8
Message was sent while issue was closed.
Change committed as 169762

Powered by Google App Engine
This is Rietveld 408576698