Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index d3558150c8df8a94cb7e4dcf61581f88274db592..8a77489e6fc1be74f317155d4657a0a112fb6b48 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -1200,7 +1200,8 @@ void ViewSource(Browser* browser,
   last_committed_entry->SetPageState(page_state.RemoveScrollOffset());
 
   // Do not restore title, derive it from the url.
-  last_committed_entry->SetTitle(base::string16());
+  view_source_contents->UpdateTitleForEntry(last_committed_entry,
+                                            base::string16());

[Charlie Reis, 2016/07/13 21:02:23]

I think this should be safe.  Technically we might not need it in this case
because we haven't loaded the page yet-- we're just configuring the
NavigationEntry before the load happens (e.g., removing the scroll offset on the
line above).  We might generate an extra notification as a result of this, but I
think that's probably ok.

[afakhry, 2016/07/13 22:10:27]

Acknowledged.

 
   // Now show view-source entry.
   if (browser->CanSupportWindowFeature(Browser::FEATURE_TABSTRIP)) {