Using WebContents::UpdateTitleForEntry() instead of NavigationEntry::SetTitle()

chrome/browser/media/tab_desktop_media_list_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/tab_desktop_media_list.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/location.h"
 #include "base/run_loop.h"
@@ skipping 121 matching lines @@
     if (!entry) {
       std::unique_ptr<content::NavigationEntry> entry_new =
           content::NavigationController::CreateNavigationEntry(
               GURL("chrome://blank"), content::Referrer(),
               ui::PAGE_TRANSITION_LINK, false, std::string(), profile_);
 
       contents->GetController().SetTransientEntry(std::move(entry_new));
       entry = contents->GetController().GetTransientEntry();
     }
 
-    entry->SetTitle(base::UTF8ToUTF16("Test tab"));
+    contents->UpdateTitleForEntry(entry, base::UTF8ToUTF16("Test tab"));

[Lei Zhang, 2016/07/13 23:17:17]

ASCIIToUTF16() while we are here? Ditto on line 330.

[afakhry, 2016/07/13 23:36:17]

Done.

 
     content::FaviconStatus favicon_info;
     favicon_info.image =
         CreateGrayscaleImage(gfx::Size(10, 10), favicon_greyscale);
     entry->GetFavicon() = favicon_info;
 
     contents_array_.push_back(std::move(contents));
     tab_strip_model->AppendWebContents(contents_array_.back().get(), false);
   }
 
@@ skipping 165 matching lines @@
 
 TEST_F(TabDesktopMediaListTest, UpdateTitle) {
   InitializeAndVerify();
 
   // Change tab's title.
   TabStripModel* tab_strip_model = browser_->tab_strip_model();
   ASSERT_TRUE(tab_strip_model);
   WebContents* contents =
       tab_strip_model->GetWebContentsAt(kDefaultSourceCount - 1);
   ASSERT_TRUE(contents);
-  contents->GetController().GetTransientEntry()->SetTitle(
-      base::UTF8ToUTF16("New test tab"));
+  content::NavigationController* controller = &contents->GetController();

[Lei Zhang, 2016/07/13 23:17:17]

Just use a const ref?

[afakhry, 2016/07/13 23:36:17]

Done.

+  contents->UpdateTitleForEntry(controller->GetTransientEntry(),
+                                base::UTF8ToUTF16("New test tab"));
 
   EXPECT_CALL(observer_, OnSourceNameChanged(list_.get(), 0))
       .WillOnce(QuitMessageLoop());
 
   base::RunLoop().Run();
 
   EXPECT_EQ(list_->GetSource(0).name, base::UTF8ToUTF16("New test tab"));
 
   list_.reset();
 }
@@ skipping 12 matching lines @@
   favicon_info.image = CreateGrayscaleImage(gfx::Size(10, 10), 100);
   contents->GetController().GetTransientEntry()->GetFavicon() = favicon_info;
 
   EXPECT_CALL(observer_, OnSourceThumbnailChanged(list_.get(), 0))
       .WillOnce(QuitMessageLoop());
 
   base::RunLoop().Run();
 
   list_.reset();
 }