Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2086363002: Remove calls to deprecated MessageLoop methods in sync. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in sync. This CL makes the following replacements in sync: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=maxbogue@chromium.org Committed: https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff Cr-Commit-Position: refs/heads/master@{#401379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M sync/internal_api/public/base/cancelation_signal_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M sync/internal_api/public/util/weak_handle_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/tools/sync_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sync/util/get_session_name_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:41:23 UTC) #1
maxbogue
lgtm
4 years, 6 months ago (2016-06-22 18:54:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086363002/1
4 years, 6 months ago (2016-06-22 19:01:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 19:07:31 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 19:09:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68e6a5844a09c6410421210c95ba3c84b0b7cdff
Cr-Commit-Position: refs/heads/master@{#401379}

Powered by Google App Engine
This is Rietveld 408576698