milo: put line breaks between step text strings

milo: put line breaks between step text strings

divs are used instead of br because putting <br> before each line except first one is surprisingly complicated. in particular, {{join .Text "<br"}} will escape <br>

also divs are more semantic, so it is kind of the way it should be done

R=hinoka@chromium.org, estaab@chromium.org
BUG=622503
Committed: https://github.com/luci/luci-go/commit/66d8950942a7d3850db0e3808fe93e7464d41dc4

[nodir, 2016-06-22 23:52:18]

Description was changed from

==========
milo: put line breaks between step text strings

R=hinoka@chromium.org, estaab@chromium.org
BUG=622503
==========

to

==========
milo: put line breaks between step text strings

divs are used instead of br because putting <br> before each line except first
one is surprisingly complicated. in particular, {{join .Text "<br"}} will escape
<br>

also divs are more semantic, so it is kind of the way it should be done

R=hinoka@chromium.org, estaab@chromium.org
BUG=622503
==========

[nodir, 2016-06-22 23:52:33]

PTAL

[Ryan Tseng, 2016-06-23 00:45:34]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2016-06-23 00:45:35]

lgtm

https://codereview.chromium.org/2086353004/diff/20001/appengine/cmd/milo/fron...
File appengine/cmd/milo/frontend/static/buildbot/css/default.css (right):

https://codereview.chromium.org/2086353004/diff/20001/appengine/cmd/milo/fron...
appengine/cmd/milo/frontend/static/buildbot/css/default.css:703:
div.step-text:first-child {
This feels like a hack ... But oh well, might be better than the <br> hackery,
I'm not actually sure whats idiomatic.

[nodir, 2016-06-23 01:04:39]

https://codereview.chromium.org/2086353004/diff/20001/appengine/cmd/milo/fron...
File appengine/cmd/milo/frontend/static/buildbot/css/default.css (right):

https://codereview.chromium.org/2086353004/diff/20001/appengine/cmd/milo/fron...
appengine/cmd/milo/frontend/static/buildbot/css/default.css:703:
div.step-text:first-child {
On 2016/06/23 00:45:35, Ryan Tseng wrote:
> This feels like a hack ... But oh well, might be better than the <br> hackery,
> I'm not actually sure whats idiomatic.

Specifying how stuff should look like in CSS shouldn't be hackery? It is CSS's
purpose,t but I'm not a frontend dev

[nodir, 2016-06-23 01:04:49]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-06-23 01:04:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086353004/20001

[commit-bot: I haz the power, 2016-06-23 01:11:39]

Description was changed from

==========
milo: put line breaks between step text strings

divs are used instead of br because putting <br> before each line except first
one is surprisingly complicated. in particular, {{join .Text "<br"}} will escape
<br>

also divs are more semantic, so it is kind of the way it should be done

R=hinoka@chromium.org, estaab@chromium.org
BUG=622503
==========

to

==========
milo: put line breaks between step text strings

divs are used instead of br because putting <br> before each line except first
one is surprisingly complicated. in particular, {{join .Text "<br"}} will escape
<br>

also divs are more semantic, so it is kind of the way it should be done

R=hinoka@chromium.org, estaab@chromium.org
BUG=622503

Committed:
https://github.com/luci/luci-go/commit/66d8950942a7d3850db0e3808fe93e7464d41dc4
==========

[commit-bot: I haz the power, 2016-06-23 01:11:40]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/66d8950942a7d3850db0e3808fe93e7464d41dc4

[nodir, 2016-06-23 03:35:38]

Deployed