Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2086353002: Remove calls to deprecated MessageLoop methods in media. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 5 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, imcheng+watch_chromium.org, toyoshim+midi_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in media. This CL makes the following replacements in media: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=chcunningham@chromium.org Committed: https://crrev.com/f920dcf7ef1f0cd43ffcada2918d23d41f1c8428 Cr-Commit-Position: refs/heads/master@{#402209}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -375 lines) Patch
M media/audio/audio_input_controller_unittest.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/audio/fake_audio_worker_unittest.cc View 6 chunks +28 lines, -21 lines 0 comments Download
M media/audio/mac/audio_device_listener_mac_unittest.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M media/base/bind_to_current_loop_unittest.cc View 11 chunks +11 lines, -10 lines 0 comments Download
M media/base/demuxer_perftest.cc View 6 chunks +9 lines, -5 lines 0 comments Download
M media/base/fake_demuxer_stream_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 26 chunks +30 lines, -29 lines 0 comments Download
M media/base/serial_runner_unittest.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M media/base/text_renderer_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M media/blink/buffered_data_source_unittest.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M media/blink/video_frame_compositor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/file_video_capture_device.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M media/cast/test/cast_benchmarks.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M media/cast/test/receiver.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/test/sender.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cdm/cdm_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 22 chunks +25 lines, -25 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 10 chunks +10 lines, -9 lines 0 comments Download
M media/filters/decrypting_demuxer_stream_unittest.cc View 15 chunks +15 lines, -14 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 22 chunks +50 lines, -48 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/filters/pipeline_controller_unittest.cc View 11 chunks +17 lines, -16 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 28 chunks +30 lines, -29 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 10 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:41:23 UTC) #1
chcunningham
lgtm
4 years, 5 months ago (2016-06-23 20:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086353002/1
4 years, 5 months ago (2016-06-23 20:08:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/25743) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-06-23 20:11:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086353002/20001
4 years, 5 months ago (2016-06-23 20:41:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/251593)
4 years, 5 months ago (2016-06-23 23:25:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086353002/20001
4 years, 5 months ago (2016-06-27 03:40:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/245662)
4 years, 5 months ago (2016-06-27 04:28:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086353002/20001
4 years, 5 months ago (2016-06-27 15:45:35 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 17:17:12 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 17:19:12 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f920dcf7ef1f0cd43ffcada2918d23d41f1c8428
Cr-Commit-Position: refs/heads/master@{#402209}

Powered by Google App Engine
This is Rietveld 408576698