Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2086343002: [mips] Fix using signaling NaN for holes in fixed double arrays. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-port_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mips] Fix using signaling NaN for holes in fixed double arrays. BUG=chromium:620650 Committed: https://crrev.com/a81c66546ee4ce85bf6894b087a898752cc651d1 Cr-Commit-Position: refs/heads/master@{#37207}

Patch Set 1 #

Patch Set 2 : The right fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -40 lines) Patch
M src/mips/macro-assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 3 chunks +19 lines, -40 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-620650.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086343002/1
4 years, 6 months ago (2016-06-22 13:50:58 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-22 13:51:08 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/3597) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-22 14:05:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086343002/20001
4 years, 6 months ago (2016-06-22 14:09:19 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 14:32:32 UTC) #11
Benedikt Meurer
Nice. LGTM.
4 years, 6 months ago (2016-06-22 17:38:59 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086343002/40001
4 years, 6 months ago (2016-06-23 08:01:06 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 08:24:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086343002/40001
4 years, 6 months ago (2016-06-23 08:25:17 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-23 08:27:02 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 08:28:03 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a81c66546ee4ce85bf6894b087a898752cc651d1
Cr-Commit-Position: refs/heads/master@{#37207}

Powered by Google App Engine
This is Rietveld 408576698