scripts/slave/recipe_modules/webrtc/api.py - Issue 2086333004: WebRTC: Remove get_version step from WebRTC bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 2086333004: WebRTC: Remove get_version step from WebRTC bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/api.py ('k') | scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/webrtc/api.py

diff --git a/scripts/slave/recipe_modules/webrtc/api.py b/scripts/slave/recipe_modules/webrtc/api.py

index 5f1460eb6b1c4f25ca9ea86b42831d0c496e1df9..8769e86861f254d0c963a1be3c884db045b490c3 100644

--- a/scripts/slave/recipe_modules/webrtc/api.py

+++ b/scripts/slave/recipe_modules/webrtc/api.py

@@ -183,7 +183,10 @@ class WebRTCApi(recipe_api.RecipeApi):

test.run(self, suffix='')

if self.m.chromium.c.TARGET_PLATFORM == 'android':

- self.m.chromium_android.common_tests_final_steps()

+ self.m.chromium_android.shutdown_device_monitor()

jbudorick 2016/06/23 07:50:25 Fine with this to fix the bots, but I'd prefer we

kjellander_chromium 2016/06/23 09:49:24 OK. I'll be OOO for 5 weeks starting tomorrow, so

jbudorick 2016/06/23 09:51:23 Hah, works for me. Enjoy your time off!

+ self.m.chromium_android.logcat_dump(gs_bucket='chromium-android')

+ self.m.chromium_android.stack_tool_steps(force_latest_version=True)

+ self.m.chromium_android.test_report()

with self.m.step.defer_results():

for test in tests: