WebRTC: Remove get_version step from WebRTC bots.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import datetime
 import json
 import os
 import re
 import sys
@@ skipping 341 matching lines @@
         devices = json.loads(file_contents)
         self.m.step.active_result.presentation.step_text += (
             'file format is json, reverting')
         old_format = '\n'.join(devices)
         self.m.file.write(
             'revert_device_file', self.known_devices_file, old_format)
       except ValueError:
         # File wasn't json, so no need to revert.
         self.m.step.active_result.presentation.step_text += (
             'file format is compatible')
- 
+
   def device_status_check(self, restart_usb=False, **kwargs):
     # TODO(bpastene): Remove once chromium revisions prior to
     # crrev.com/1faecde0c03013b6cd725da413339c60223f8948 are no longer tested.
     # See crbug.com/619707 for context.
     self.revert_device_file_format()
 
     # TODO(phajdan.jr): Remove path['build'] usage, http://crbug.com/437264 .
     args = [
         '--adb-path', self.m.adb.adb_path(),
         '--blacklist-file', self.blacklist_file,
@@ skipping 480 matching lines @@
           'logcat_dump',
           self.package_repo_resource('scripts', 'slave', 'tee.py'),
           [self.m.chromium.output_dir.join('full_log'),
            '--',
            self.m.path['checkout'].join('build', 'android',
                                         'adb_logcat_printer.py'),
            self.m.path['checkout'].join('out', 'logcat')],
           infra_step=True,
           )
 
-  def stack_tool_steps(self):
+  def stack_tool_steps(self, force_latest_version=False):
     build_dir = self.m.path['checkout'].join('out',
                                              self.m.chromium.c.BUILD_CONFIG)
     log_file = build_dir.join('full_log')
     target_arch = self.m.chromium.c.gyp_env.GYP_DEFINES['target_arch']
     # gyp converts ia32 to x86, bot needs to do the same
     target_arch = {'ia32': 'x86'}.get(target_arch) or target_arch
 
     # --output-directory hasn't always exited on these scripts, so use the
     # CHROMIUM_OUTPUT_DIR environment variable to avoid unrecognized flag
     # failures on older script versions (e.g. when doing bisects).
     # TODO(agrieve): Switch to --output-directory once we don't need bisects
     #     to be able to try revisions that happened before Feb 2016.
     env = self.m.chromium.get_env()
     env['CHROMIUM_OUTPUT_DIR'] = str(build_dir)
     self.m.step(
         'stack_tool_with_logcat_dump',
         [self.m.path['checkout'].join('third_party', 'android_platform',
                               'development', 'scripts', 'stack'),
          '--arch', target_arch, '--more-info', log_file],
         env=env,
         infra_step=True)
     tombstones_cmd = [
         self.m.path['checkout'].join('build', 'android', 'tombstones.py'),
         '-a', '-s', '-w',
     ]
-    if int(self.m.chromium.get_version().get('MAJOR', 0)) > 52:
+    if (force_latest_version or
+        int(self.m.chromium.get_version().get('MAJOR', 0)) > 52):
       tombstones_cmd += ['--adb-path', self.m.adb.adb_path()]
     self.m.step(
         'stack_tool_for_tombstones',
         tombstones_cmd,
         env=env,
         infra_step=True)
     if self.c.asan_symbolize:
       self.m.step(
           'stack_tool_for_asan',
           [self.m.path['checkout'].join('build',
@@ skipping 158 matching lines @@
     # WebView user agent is changed, and new CTS hasn't been published to
     # reflect that.
     expected_failure_json = self.m.file.read(
         'Fetch the expected failures tests for CTS from chromium checkout',
         _CTS_CONFIG_SRC_PATH.join('expected_failure_on_bot.json'),
         test_data = '''
                         {
                           "android.webkit.cts.ExampleBlacklistedTest":
                             [
                               {
-                                "name": "testA", 
+                                "name": "testA",
                                 "_bug_id": "crbug.com/123"
                               },
                               {"name": "testB"}
                             ]
                           }'''
         )
     expected_failure = self.m.json.loads(expected_failure_json)
-    
+
     cts_base_dir = self.m.path['build'].join('site_config', 'cts')
     cts_zip_path = cts_base_dir.join(_cts_file_name)
     cts_extract_dir = cts_base_dir.join('unzipped')
     if not self.m.path.exists(cts_zip_path):
       with self.m.step.nest('Update CTS'):
         # Remove all old cts files before downloading new one.
         self.m.file.rmtree('Delete old CTS', cts_base_dir)
         self.m.file.makedirs('Create CTS dir', cts_base_dir)
         self.m.gsutil.download(name='Download new CTS',
                                bucket='chromium-cts',
@@ skipping 37 matching lines @@
 
     for test_class in test_classes:
       class_name = 'android.webkit.cts.%s' % test_class.get('name')
       test_methods = test_class.findall('./Test')
 
       for test_method in test_methods:
         method_name = '%s#%s' % (class_name, test_method.get('name'))
         if test_method.get('result') == 'notExecuted':
           not_executed_tests.append(method_name)
         elif (test_method.find('./FailedScene') is not None and
-              test_method.get('name') not in 
-                [ t.get('name') for t in 
+              test_method.get('name') not in
+                [ t.get('name') for t in
                   expected_failure.get(class_name, []) ]):
           unexpected_test_failures.append(method_name)
 
     if unexpected_test_failures or not_executed_tests:
       self.m.step.active_result.presentation.status = self.m.step.FAILURE
       self.m.step.active_result.presentation.step_text += (
           self.m.test_utils.format_step_text(
               [['unexpected failures:', unexpected_test_failures],
                ['not executed:', not_executed_tests]]))
 
@@ skipping 212 matching lines @@
       script = self.c.test_runner
       if wrapper_script_suite_name:
         script = self.m.chromium.output_dir.join('bin', 'run_%s' %
                                                  wrapper_script_suite_name)
       else:
         env = kwargs.get('env', {})
         env['CHROMIUM_OUTPUT_DIR'] = env.get('CHROMIUM_OUTPUT_DIR',
                                              self.m.chromium.output_dir)
         kwargs['env'] = env
       return self.m.python(step_name, script, args, **kwargs)