Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 208633002: [Code cleanup]Remove webui virtual keyboard code (Closed)

Created:
6 years, 9 months ago by bshe
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Shu Chen
Visibility:
Public.

Description

[Code cleanup]Remove webui virtual keyboard code BUG=354657 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259486

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -911 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard.cc View 2 chunks +0 lines, -60 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_constants.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_constants.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller_proxy.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M ui/keyboard/keyboard_controller_proxy.cc View 1 3 chunks +1 line, -45 lines 0 comments Download
M ui/keyboard/keyboard_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/keyboard/keyboard_ui_controller.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/keyboard/keyboard_ui_controller.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D ui/keyboard/keyboard_ui_handler.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/keyboard/keyboard_ui_handler.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D ui/keyboard/resources/layouts/webui_qwerty.html View 1 chunk +0 lines, -122 lines 0 comments Download
D ui/keyboard/resources/webui/api_adapter.js View 1 chunk +0 lines, -89 lines 0 comments Download
D ui/keyboard/resources/webui/constants.js View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/keyboard/resources/webui/main.css View 1 chunk +0 lines, -172 lines 0 comments Download
D ui/keyboard/resources/webui_index.html View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bshe
Hey Sadrul. Do you mind to take a look at this? The webui virtual keyboard ...
6 years, 9 months ago (2014-03-21 19:36:35 UTC) #1
sadrul
LGTM Can you please verify that ash_shell doesn't crash on text-input focus if the keyboard ...
6 years, 9 months ago (2014-03-22 15:28:44 UTC) #2
bshe
Thanks. ash_shell doesn't crash in that case. We now rely on OnShowImeIfNeeded to show the ...
6 years, 9 months ago (2014-03-24 15:11:43 UTC) #3
miket_OOO
> +miket for chrome/common/extensions/manifest_url_handler.cc This part LGTM
6 years, 9 months ago (2014-03-24 18:08:28 UTC) #4
Nikita (slow)
lgtm so we always use extension based virtual keyboard?
6 years, 9 months ago (2014-03-25 14:43:30 UTC) #5
bshe
On 2014/03/25 14:43:30, Nikita Kostylev wrote: > lgtm > > so we always use extension ...
6 years, 9 months ago (2014-03-25 23:37:39 UTC) #6
bshe
The CQ bit was checked by bshe@chromium.org
6 years, 9 months ago (2014-03-25 23:37:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/208633002/40001
6 years, 9 months ago (2014-03-25 23:39:12 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 04:43:17 UTC) #9
Message was sent while issue was closed.
Change committed as 259486

Powered by Google App Engine
This is Rietveld 408576698