third_party/WebKit/Source/core/page/PointerLockController.cpp - Issue 2086293004: Document/ShadowRoot split of pointerLockElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PointerLockController.cpp

Issue 2086293004: Document/ShadowRoot split of pointerLockElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/PointerLockController.cpp

diff --git a/third_party/WebKit/Source/core/page/PointerLockController.cpp b/third_party/WebKit/Source/core/page/PointerLockController.cpp

index 72ee211b26cb4822e86bb9dcc944cb7bd0592bc0..eeeeea87c1e0c80ba555c6be783bc5009c0dccb3 100644

--- a/third_party/WebKit/Source/core/page/PointerLockController.cpp

+++ b/third_party/WebKit/Source/core/page/PointerLockController.cpp

@@ -53,6 +53,8 @@ void PointerLockController::requestPointerLock(Element* target)

}

UseCounter::countCrossOriginIframe(target->document(), UseCounter::ElementRequestPointerLockIframe);

+ if (target->isInShadowTree())

+ UseCounter::count(target->document(), UseCounter::ElementRequestPointerLockInShadow);

if (target->document().isSandboxed(SandboxPointerLock)) {

// FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.