Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp

Issue 2086283002: Convert CSSParserToken::valueEqualsIgnoringASCIICase to equalIgnoringASCIICase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp b/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
index 4273532d34d1356911e66bfb965b46e76fa426a4..5bf6a3f799c8a4671447fe4249c10af47b4bec68 100644
--- a/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
@@ -64,7 +64,7 @@ void MediaQueryParser::readRestrictor(CSSParserTokenType type, const CSSParserTo
void MediaQueryParser::readMediaNot(CSSParserTokenType type, const CSSParserToken& token)
{
- if (type == IdentToken && token.valueEqualsIgnoringASCIICase("not"))
+ if (type == IdentToken && equalIgnoringASCIICase(token.value(), "not"))
setStateAndRestrict(ReadFeatureStart, MediaQuery::Not);
else
readFeatureStart(type, token);
@@ -73,10 +73,10 @@ void MediaQueryParser::readMediaNot(CSSParserTokenType type, const CSSParserToke
static bool isRestrictorOrLogicalOperator(const CSSParserToken& token)
{
// FIXME: it would be more efficient to use lower-case always for tokenValue.
- return token.valueEqualsIgnoringASCIICase("not")
- || token.valueEqualsIgnoringASCIICase("and")
- || token.valueEqualsIgnoringASCIICase("or")
- || token.valueEqualsIgnoringASCIICase("only");
+ return equalIgnoringASCIICase(token.value(), "not")
+ || equalIgnoringASCIICase(token.value(), "and")
+ || equalIgnoringASCIICase(token.value(), "or")
+ || equalIgnoringASCIICase(token.value(), "only");
}
void MediaQueryParser::readMediaType(CSSParserTokenType type, const CSSParserToken& token)
@@ -87,9 +87,9 @@ void MediaQueryParser::readMediaType(CSSParserTokenType type, const CSSParserTok
else
m_state = ReadFeature;
} else if (type == IdentToken) {
- if (m_state == ReadRestrictor && token.valueEqualsIgnoringASCIICase("not")) {
+ if (m_state == ReadRestrictor && equalIgnoringASCIICase(token.value(), "not")) {
setStateAndRestrict(ReadMediaType, MediaQuery::Not);
- } else if (m_state == ReadRestrictor && token.valueEqualsIgnoringASCIICase("only")) {
+ } else if (m_state == ReadRestrictor && equalIgnoringASCIICase(token.value(), "only")) {
setStateAndRestrict(ReadMediaType, MediaQuery::Only);
} else if (m_mediaQueryData.restrictor() != MediaQuery::None
&& isRestrictorOrLogicalOperator(token)) {
@@ -109,7 +109,7 @@ void MediaQueryParser::readMediaType(CSSParserTokenType type, const CSSParserTok
void MediaQueryParser::readAnd(CSSParserTokenType type, const CSSParserToken& token)
{
- if (type == IdentToken && token.valueEqualsIgnoringASCIICase("and")) {
+ if (type == IdentToken && equalIgnoringASCIICase(token.value(), "and")) {
m_state = ReadFeatureStart;
} else if (type == CommaToken && m_parserType != MediaConditionParser) {
m_querySet->addMediaQuery(m_mediaQueryData.takeMediaQuery());

Powered by Google App Engine
This is Rietveld 408576698