[Mac] Reveal Fullscreen Toolbar for Tab Strip Changes

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 #include <utility>
 
@@ skipping 1011 matching lines @@
     manager = PermissionBubbleManager::FromWebContents(oldContents);
     if (manager)
       manager->HideBubble();
   }
 
   if (newContents) {
     manager = PermissionBubbleManager::FromWebContents(newContents);
     if (manager)
       manager->DisplayPendingRequests();
   }
+
+  // If the web contents want to focus on the location bar, do not call the
+  // animation since the location bar will drop down when it's focused.
+  bool will_focus_location_bar =

[Robert Sesek, 2016/06/23 14:08:24]

naming: camelCase

[spqchan, 2016/06/23 19:41:52]

Done.

+      newContents && newContents->FocusLocationBarByDefault();
+  if ([self isInAnyFullscreenMode] && !will_focus_location_bar)
+    [[self presentationModeController] revealToolbarForTabStripChanges];
 }
 
 - (void)zoomChangedForActiveTab:(BOOL)canShowBubble {
   [toolbarController_ zoomChangedForActiveTab:canShowBubble];
 }
 
 // Return the rect, in WebKit coordinates (flipped), of the window's grow box
 // in the coordinate system of the content area of the currently selected tab.
 // |windowGrowBox| needs to be in the window's coordinate system.
 - (NSRect)selectedTabGrowBoxRect {
@@ skipping 428 matching lines @@
   if (change != TabStripModelObserver::TITLE_NOT_LOADING) {
     windowShim_->BookmarkBarStateChanged(
         BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
   }
 }
 
 - (void)onTabDetachedWithContents:(WebContents*)contents {
   [infoBarContainerController_ tabDetachedWithContents:contents];
 }
 
+- (void)onTabInsertedInForeground:(BOOL)inForeground {
+  if ([self isInAnyFullscreenMode] && !inForeground)
+    [[self presentationModeController] revealToolbarForTabStripChanges];
+}
+
 - (void)userChangedTheme {
   NSView* rootView = [[[self window] contentView] superview];
   [rootView cr_recursivelyInvokeBlock:^(id view) {
       if ([view conformsToProtocol:@protocol(ThemedWindowDrawing)])
         [view windowDidChangeTheme];
 
       // TODO(andresantoso): Remove this once all themed views respond to
       // windowDidChangeTheme above.
       [view setNeedsDisplay:YES];
   }];
@@ skipping 566 matching lines @@
 
 - (BOOL)isTabbedWindow {
   return browser_->is_type_tabbed();
 }
 
 - (NSRect)savedRegularWindowFrame {
   return savedRegularWindowFrame_;
 }
 
 @end  // @implementation BrowserWindowController(WindowType)