Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2086273003: [Mac] Reveal Fullscreen Toolbar for Tab Strip Changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1855 matching lines...) Expand 10 before | Expand all | Expand 10 after
1866 IDS_FLAGS_GOOGLE_BRANDED_CONTEXT_MENU_NAME, 1866 IDS_FLAGS_GOOGLE_BRANDED_CONTEXT_MENU_NAME,
1867 IDS_FLAGS_GOOGLE_BRANDED_CONTEXT_MENU_DESCRIPTION, kOsDesktop, 1867 IDS_FLAGS_GOOGLE_BRANDED_CONTEXT_MENU_DESCRIPTION, kOsDesktop,
1868 SINGLE_VALUE_TYPE(switches::kEnableGoogleBrandedContextMenu)}, 1868 SINGLE_VALUE_TYPE(switches::kEnableGoogleBrandedContextMenu)},
1869 #endif 1869 #endif
1870 #if defined(OS_MACOSX) 1870 #if defined(OS_MACOSX)
1871 {"enable-fullscreen-in-tab-detaching", 1871 {"enable-fullscreen-in-tab-detaching",
1872 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_NAME, 1872 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_NAME,
1873 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_DESCRIPTION, kOsMac, 1873 IDS_FLAGS_TAB_DETACHING_IN_FULLSCREEN_DESCRIPTION, kOsMac,
1874 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableFullscreenTabDetaching, 1874 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableFullscreenTabDetaching,
1875 switches::kDisableFullscreenTabDetaching)}, 1875 switches::kDisableFullscreenTabDetaching)},
1876 {"enable-fullscreen-toolbar-reveal",
1877 IDS_FLAGS_FULLSCREEN_TOOLBAR_REVEAL_NAME,
1878 IDS_FLAGS_FULLSCREEN_TOOLBAR_REVEAL_DESCRIPTION, kOsMac,
1879 SINGLE_VALUE_TYPE(switches::kEnableFullscreenToolbarReveal)},
1876 #endif 1880 #endif
1877 #if defined(OS_ANDROID) 1881 #if defined(OS_ANDROID)
1878 {"media-style-notification", IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_NAME, 1882 {"media-style-notification", IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_NAME,
1879 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_DESCRIPTION, kOsAndroid, 1883 IDS_FLAGS_MEDIA_STYLE_NOTIFICATION_DESCRIPTION, kOsAndroid,
1880 FEATURE_VALUE_TYPE(chrome::android::kMediaStyleNotification)}, 1884 FEATURE_VALUE_TYPE(chrome::android::kMediaStyleNotification)},
1881 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME, 1885 {"important-sites-in-cbd", IDS_FLAGS_IMPORTANT_SITES_IN_CBD_NAME,
1882 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid, 1886 IDS_FLAGS_IMPORTANT_SITES_IN_CBD_DESCRIPTION, kOsAndroid,
1883 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)}, 1887 FEATURE_VALUE_TYPE(chrome::android::kImportantSitesInCBD)},
1884 {"enable-autoplay-muted-videos", 1888 {"enable-autoplay-muted-videos",
1885 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME, 1889 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_NAME,
1886 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, 1890 IDS_FLAGS_ENABLE_AUTOPLAY_MUTED_VIDEOS_DESCRIPTION, kOsAndroid,
1887 kOsAndroid,
1888 SINGLE_VALUE_TYPE(switches::kEnableAutoplayMutedVideos)}, 1891 SINGLE_VALUE_TYPE(switches::kEnableAutoplayMutedVideos)},
1889 #endif 1892 #endif
1890 {"enable-pointer-events", // FLAGS:RECORD_UMA 1893 {"enable-pointer-events", // FLAGS:RECORD_UMA
1891 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME, 1894 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_NAME,
1892 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll, 1895 IDS_FLAGS_EXPERIMENTAL_POINTER_EVENT_DESCRIPTION, kOsAll,
1893 FEATURE_VALUE_TYPE(features::kPointerEvents)}, 1896 FEATURE_VALUE_TYPE(features::kPointerEvents)},
1894 {"passive-listener-default", // FLAGS:RECORD_UMA 1897 {"passive-listener-default", // FLAGS:RECORD_UMA
1895 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_NAME, 1898 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_NAME,
1896 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_DESCRIPTION, kOsAll, 1899 IDS_FLAGS_PASSIVE_EVENT_LISTENER_DEFAULT_DESCRIPTION, kOsAll,
1897 MULTI_VALUE_TYPE(kPassiveListenersChoices)}, 1900 MULTI_VALUE_TYPE(kPassiveListenersChoices)},
1898 {"enable-loading-ipc-optimization-for-small-resources", 1901 {"enable-loading-ipc-optimization-for-small-resources",
1899 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_NAME, 1902 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_NAME,
1900 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_DESCRIPTION, kOsAll, 1903 IDS_FLAGS_OPTIMIZE_LOADING_IPC_FOR_SMALL_RESOURCES_DESCRIPTION, kOsAll,
1901 FEATURE_VALUE_TYPE(features::kOptimizeLoadingIPCForSmallResources)}, 1904 FEATURE_VALUE_TYPE(features::kOptimizeLoadingIPCForSmallResources)},
1902 {"enable-font-cache-scaling", IDS_FLAGS_FONT_CACHE_SCALING_NAME, 1905 {"enable-font-cache-scaling", IDS_FLAGS_FONT_CACHE_SCALING_NAME,
1903 IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION, kOsAll, 1906 IDS_FLAGS_FONT_CACHE_SCALING_DESCRIPTION, kOsAll,
1904 FEATURE_VALUE_TYPE(features::kFontCacheScaling)}, 1907 FEATURE_VALUE_TYPE(features::kFontCacheScaling)},
1905 #if defined(OS_ANDROID) 1908 #if defined(OS_ANDROID)
1906 {"enable-vr-shell", 1909 {"enable-vr-shell", IDS_FLAGS_ENABLE_VR_SHELL_NAME,
1907 IDS_FLAGS_ENABLE_VR_SHELL_NAME,
1908 IDS_FLAGS_ENABLE_VR_SHELL_DESCRIPTION, kOsAndroid, 1910 IDS_FLAGS_ENABLE_VR_SHELL_DESCRIPTION, kOsAndroid,
1909 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableVrShell, 1911 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableVrShell,
1910 switches::kDisableVrShell)}, 1912 switches::kDisableVrShell)},
1911 #endif 1913 #endif
1912 1914
1913 {"enable-weak-memorycache", 1915 {"enable-weak-memorycache", IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_NAME,
1914 IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_NAME,
1915 IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_DESCRIPTION, kOsAll, 1916 IDS_FLAGS_ENABLE_WEAK_MEMORYCACHE_DESCRIPTION, kOsAll,
1916 FEATURE_VALUE_TYPE(features::kWeakMemoryCache)}, 1917 FEATURE_VALUE_TYPE(features::kWeakMemoryCache)},
1917 // NOTE: Adding new command-line switches requires adding corresponding 1918 // NOTE: Adding new command-line switches requires adding corresponding
1918 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1919 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1919 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1920 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1920 }; 1921 };
1921 1922
1922 class FlagsStateSingleton { 1923 class FlagsStateSingleton {
1923 public: 1924 public:
1924 FlagsStateSingleton() 1925 FlagsStateSingleton()
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
2106 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2107 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2107 2108
2108 const FeatureEntry* GetFeatureEntries(size_t* count) { 2109 const FeatureEntry* GetFeatureEntries(size_t* count) {
2109 *count = arraysize(kFeatureEntries); 2110 *count = arraysize(kFeatureEntries);
2110 return kFeatureEntries; 2111 return kFeatureEntries;
2111 } 2112 }
2112 2113
2113 } // namespace testing 2114 } // namespace testing
2114 2115
2115 } // namespace about_flags 2116 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698