[Mac] Reveal Fullscreen Toolbar for Tab Strip Changes

chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <stddef.h>
 #import "base/mac/mac_util.h"
 
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/devtools/devtools_window_testing.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_navigator.h"
+#include "chrome/browser/ui/browser_navigator_params.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
 #import "chrome/browser/ui/cocoa/history_overlay_controller.h"
 #import "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h"
 #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h"
 #import "chrome/browser/ui/cocoa/infobars/infobar_controller.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 #import "chrome/browser/ui/cocoa/presentation_mode_controller.h"
 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
 #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
+#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/infobar_container_delegate.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/infobars/core/infobar_delegate.h"
 #include "components/infobars/core/simple_alert_infobar_delegate.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #import "testing/gtest_mac.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 #import "ui/base/cocoa/nsview_additions.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/gfx/vector_icons_public.h"
 
 namespace {
 
 // Creates a mock of an NSWindow that has the given |frame|.
@@ skipping 113 matching lines @@
 
   // Exceptions are allowed to overlap |exposed_view_|. Exceptions must still
   // be Z-order behind |exposed_view_|.
   base::scoped_nsobject<NSArray> exceptions_;
 
   DISALLOW_COPY_AND_ASSIGN(ViewExposedChecker);
 };
 
 }  // namespace
 
+// Mock PresentationModeController used to test if the toolbar reveal animation
+// is called correctly.
+@interface MockPresentationModeController : PresentationModeController
+
+// True if revealToolbarForTabStripChanges was called.
+@property(nonatomic, assign) BOOL isRevealingToolbarForTabstrip;
+
+// Initializer.
+- (id)initWithBrowserController:(BrowserWindowController*)controller;
+
+// Sets isRevealingToolbarForTabstrip back to false.
+- (void)resetToolbarFlag;
+
+// Overridden to set isRevealingToolbarForTabstrip to true when it's called.
+- (void)revealToolbarForTabStripChanges;
+
+// Overridden so that we don't have to deal with the DCHECKs when the
+// BWC exits fullscreen.
+- (void)exitPresentationMode;
+
+@end
+
+@implementation MockPresentationModeController
+
+@synthesize isRevealingToolbarForTabstrip = isRevealingToolbarForTabstrip_;
+
+- (id)initWithBrowserController:(BrowserWindowController*)controller {
+  if ((self = [super
+           initWithBrowserController:controller
+                               style:fullscreen_mac::OMNIBOX_TABS_HIDDEN])) {
+  }
+
+  return self;
+}
+
+- (void)resetToolbarFlag {
+  isRevealingToolbarForTabstrip_ = NO;
+}
+
+- (void)revealToolbarForTabStripChanges {
+  isRevealingToolbarForTabstrip_ = YES;
+}
+
+- (void)exitPresentationMode {
+}
+
+@end
+
 @interface InfoBarContainerController(TestingAPI)
 - (BOOL)isTopInfoBarAnimationRunning;
 @end
 
 @implementation InfoBarContainerController(TestingAPI)
 - (BOOL)isTopInfoBarAnimationRunning {
   InfoBarController* infoBarController = [infobarControllers_ objectAtIndex:0];
   if (infoBarController) {
     const gfx::SlideAnimation& infobarAnimation =
         static_cast<const InfoBarCocoa*>(
@@ skipping 189 matching lines @@
     waiter->Wait();
   }
 
   // Verifies that the flags |blockLayoutSubviews_| and |blockFullscreenResize|
   // are false.
   void VerifyFullscreenResizeFlagsAfterTransition() {
     ASSERT_FALSE([controller() isLayoutSubviewsBlocked]);
     ASSERT_FALSE([controller() isActiveTabContentsControllerResizeBlocked]);
   }
 
+  // Inserts a new tab into the tabstrip at the background.
+  void AddTabAtBackground(int index, GURL url) {
+    chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
+    params.tabstrip_index = index;
+    params.disposition = NEW_BACKGROUND_TAB;
+    chrome::Navigate(&params);
+    content::WaitForLoadStopWithoutSuccessCheck(params.target_contents);
+  }
+
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserWindowControllerTest);
 };
 
 // Tests that adding the first profile moves the Lion fullscreen button over
 // correctly.
 // DISABLED_ because it regularly times out: http://crbug.com/159002.
 IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
                        DISABLED_ProfileAvatarFullscreenButton) {
   // Initialize the locals.
@@ skipping 306 matching lines @@
   // Toggle out and back into fullscreen and verify that the toolbar is still
   // hidden.
   ToggleFullscreenAndWaitForNotification();
   ToggleFullscreenAndWaitForNotification();
   [[controller() presentationModeController] setMenuBarRevealProgress:0.0];
   VerifyFullscreenToolbarVisibility(fullscreen_mac::OMNIBOX_TABS_HIDDEN);
 
   chrome::ExecuteCommand(browser(), IDC_TOGGLE_FULLSCREEN_TOOLBAR);
   EXPECT_TRUE(prefs->GetBoolean(prefs::kShowFullscreenToolbar));
 }
+
+// Tests that the toolbar (tabstrip and omnibox) reveal animation is correctly
+// triggered by the changes in the tabstrip. The animation should not trigger
+// if the current tab is a NTP, since the location bar would be focused.
+IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
+                       FullscreenToolbarExposedForTabstripChanges) {
+  MockPresentationModeController* presentationModeController =
+      [[MockPresentationModeController alloc]

[Robert Sesek, 2016/06/29 00:57:28]

This needs to be in scoped_nsobject now.

[spqchan, 2016/06/29 01:17:57]

Done.

+          initWithBrowserController:controller()];
+  [controller() setPresentationModeController:presentationModeController];
+
+  ToggleFullscreenAndWaitForNotification();
+
+  // Insert a non-NTP new tab in the foreground.
+  AddTabAtIndex(0, GURL("http://google.com"), ui::PAGE_TRANSITION_LINK);
+  ASSERT_FALSE([[controller() toolbarController] isLocationBarFocused]);
+  EXPECT_TRUE([presentationModeController isRevealingToolbarForTabstrip]);
+  [presentationModeController resetToolbarFlag];
+
+  // Insert a new tab in the background.
+  AddTabAtBackground(0, GURL("about:blank"));
+  EXPECT_TRUE([presentationModeController isRevealingToolbarForTabstrip]);
+  [presentationModeController resetToolbarFlag];
+
+  // Insert a NTP new tab in the foreground.
+  AddTabAtIndex(0, GURL("about:blank"), ui::PAGE_TRANSITION_LINK);
+  ASSERT_TRUE([[controller() toolbarController] isLocationBarFocused]);
+  EXPECT_FALSE([presentationModeController isRevealingToolbarForTabstrip]);
+  [presentationModeController resetToolbarFlag];
+
+  // Insert a new tab in the background. The animation should not be triggered
+  // since the location bar should still be focused.
+  AddTabAtBackground(1, GURL("http://google.com"));
+  ASSERT_TRUE([[controller() toolbarController] isLocationBarFocused]);
+  EXPECT_FALSE([presentationModeController isRevealingToolbarForTabstrip]);
+  [presentationModeController resetToolbarFlag];
+
+  // Switch to a non-NTP tab.
+  TabStripModel* model = browser()->tab_strip_model();
+  model->ActivateTabAt(1, true);
+  ASSERT_FALSE([[controller() toolbarController] isLocationBarFocused]);
+  EXPECT_TRUE([presentationModeController isRevealingToolbarForTabstrip]);
+  [presentationModeController resetToolbarFlag];
+}