Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 208623004: gclient: Change the .gclient URL mismatch warning into an error. (Closed)

Created:
6 years, 9 months ago by borenet
Modified:
6 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, skiabot_google.com, Peter Mayo, smut
Visibility:
Public.

Description

gclient: Change the .gclient URL mismatch warning into an error. BUG=skia:1638 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259681

Patch Set 1 #

Patch Set 2 : Move _CheckConfig call to beginning of RunOnDeps #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M gclient.py View 1 2 4 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
borenet
Will wait until the second half of next week to submit this.
6 years, 9 months ago (2014-03-21 19:00:01 UTC) #1
iannucci
pre-emptive lgtm
6 years, 9 months ago (2014-03-21 19:43:33 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 9 months ago (2014-03-26 20:52:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/208623004/40001
6 years, 9 months ago (2014-03-26 20:52:11 UTC) #4
commit-bot: I haz the power
Change committed as 259681
6 years, 9 months ago (2014-03-26 20:54:46 UTC) #5
tdanderson
A revert of this CL has been created in https://codereview.chromium.org/213763002/ by tdanderson@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 22:47:58 UTC) #6
iannucci
Note that this was already stealth-reverted here: https://codereview.chromium.org/213483003/
6 years, 9 months ago (2014-03-26 22:53:08 UTC) #7
iannucci
On 2014/03/26 22:53:08, iannucci wrote: > Note that this was already stealth-reverted here: > https://codereview.chromium.org/213483003/ ...
6 years, 9 months ago (2014-03-26 22:54:24 UTC) #8
iannucci
6 years, 9 months ago (2014-03-26 22:56:04 UTC) #9
Message was sent while issue was closed.
On 2014/03/26 22:54:24, iannucci wrote:
> On 2014/03/26 22:53:08, iannucci wrote:
> > Note that this was already stealth-reverted here:
> > https://codereview.chromium.org/213483003/
> 
> (and the solution is likely the same: you should pass --revision src@<rev> to
> the command line of gclient sync)

(or, we should make gclient tolerant of stuffing fixed revisions into the
.gclient file and deprecate --revision. Having many ways to do the same thing is
not so awesome.)

Powered by Google App Engine
This is Rietveld 408576698