Add //base and //buildtools to DEPS

Add //base and //buildtools to DEPS

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/9f78535bc6adb4a4eea88f2d3e9a434f91ccfc36

[Cutch, 2016-06-22 15:42:43]

Description was changed from

==========
Add //base and //buildtools to DEPS

BUG=
==========

to

==========
Add //base and //buildtools to DEPS

BUG=
==========

[Cutch, 2016-06-22 15:42:43]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[zra, 2016-06-22 15:49:10]

lgtm with cleanup

https://codereview.chromium.org/2086153003/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2086153003/diff/1/.gitignore#newcode1
.gitignore:1: # These ignores are auto-generated from the canonical svn ignore
metadata
This comment looks stale. Since you're in here would you mind removing it?

https://codereview.chromium.org/2086153003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2086153003/diff/1/DEPS#newcode32
DEPS:32: "chromium_git": "https://chromium.googlesource.com",
rm duplicate definition.

https://codereview.chromium.org/2086153003/diff/1/DEPS#newcode131
DEPS:131: Var('chromium_git') + '/external/github.com/domokit/base' + 
Var('base_revision'),
It looks like we're breaking long lines by moving e.g. Var('base_revision') down
to the next line. It also looks like we've been abbreviating revision as rev.

[Cutch, 2016-06-22 17:30:45]

https://codereview.chromium.org/2086153003/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2086153003/diff/1/.gitignore#newcode1
.gitignore:1: # These ignores are auto-generated from the canonical svn ignore
metadata
On 2016/06/22 15:49:09, zra wrote:
> This comment looks stale. Since you're in here would you mind removing it?

Done.

https://codereview.chromium.org/2086153003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2086153003/diff/1/DEPS#newcode32
DEPS:32: "chromium_git": "https://chromium.googlesource.com",
On 2016/06/22 15:49:09, zra wrote:
> rm duplicate definition.

Done.

https://codereview.chromium.org/2086153003/diff/1/DEPS#newcode131
DEPS:131: Var('chromium_git') + '/external/github.com/domokit/base' + 
Var('base_revision'),
On 2016/06/22 15:49:10, zra wrote:
> It looks like we're breaking long lines by moving e.g. Var('base_revision')
down
> to the next line. It also looks like we've been abbreviating revision as rev.

Done.

[Cutch, 2016-06-22 17:32:54]

Description was changed from

==========
Add //base and //buildtools to DEPS

BUG=
==========

to

==========
Add //base and //buildtools to DEPS

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9f78535bc6adb4a4eea88f2d3e9a434f91ccfc36
==========

[Cutch, 2016-06-22 17:32:57]

Committed patchset #2 (id:20001) manually as
9f78535bc6adb4a4eea88f2d3e9a434f91ccfc36 (presubmit successful).