Implement Referrer-Policy header for workers

Implement Referrer-Policy header for workers

This CL adds (runtime-enabled) support for the Referrer-Policy header
when loading worker scripts. If a worker script is served with a
Referrer-Policy header, then that policy is used for requests that
the worker initiates. If no Referrer-Policy header is present, then
the worker gets the default referrer policy.

Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70

BUG=619228
Committed: https://crrev.com/239c8bd69c319553a11b83041042cde6879deaab
Cr-Commit-Position: refs/heads/master@{#401953}

[estark, 2016-06-23 23:50:03]

estark@chromium.org changed reviewers:
+ jochen@chromium.org

[estark, 2016-06-23 23:50:04]

jochen, ptal? and mkwst too if you'd like

[estark, 2016-06-23 23:51:15]

(While this CL touches a lot of files, it's not very complicated: we're
basically just saving the Referrer-Policy header in WorkerScriptLoader and then
threading it through to the various worker execution contexts)

[Marijn Kruisselbrink, 2016-06-24 00:00:14]

drive-by question

https://codereview.chromium.org/2086143006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp (right):

https://codereview.chromium.org/2086143006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp:45: ,
m_referrerPolicy(referrerPolicy)
shouldn't this call referrerPolicy.isolatedCopy() to make it safe to pass the
string to a different thread (like all the other Strings that are passed to
WorkerThreadStartupData).

[estark, 2016-06-24 00:10:03]

https://codereview.chromium.org/2086143006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp (right):

https://codereview.chromium.org/2086143006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp:45: ,
m_referrerPolicy(referrerPolicy)
On 2016/06/24 00:00:14, Marijn Kruisselbrink wrote:
> shouldn't this call referrerPolicy.isolatedCopy() to make it safe to pass the
> string to a different thread (like all the other Strings that are passed to
> WorkerThreadStartupData).

Oh, yes, thank you! Done.

[Mike West, 2016-06-24 10:38:47]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-06-24 10:38:48]

LGTM with some testing nits.

https://codereview.chromium.org/2086143006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/shared-worker-with-header.html
(right):

https://codereview.chromium.org/2086143006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/shared-worker-with-header.html:8:
var worker = new
SharedWorker('http://127.0.0.1:8000/security/referrerPolicyHeader/resources/worker.php');
Nit: If you're going to use `get_host_info` below, you should use it here too.
Or just use a relative URL, as in the worker-with-header.html below.

[jochen (gone - plz use gerrit), 2016-06-24 12:03:47]

lgtm

[estark, 2016-06-24 17:34:41]

https://codereview.chromium.org/2086143006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/shared-worker-with-header.html
(right):

https://codereview.chromium.org/2086143006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/security/referrerPolicyHeader/shared-worker-with-header.html:8:
var worker = new
SharedWorker('http://127.0.0.1:8000/security/referrerPolicyHeader/resources/worker.php');
On 2016/06/24 10:38:47, Mike West wrote:
> Nit: If you're going to use `get_host_info` below, you should use it here too.
> Or just use a relative URL, as in the worker-with-header.html below.

Huh, not sure why I made that absolute. Fixed. Thanks!

[estark, 2016-06-24 17:34:50]

The CQ bit was checked by estark@chromium.org

[estark, 2016-06-24 17:34:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2086143006/#ps40001
(title: "fix shared worker path")

[commit-bot: I haz the power, 2016-06-24 17:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 20:24:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 20:25:45]

Description was changed from

==========
Implement Referrer-Policy header for workers

This CL adds (runtime-enabled) support for the Referrer-Policy header
when loading worker scripts. If a worker script is served with a
Referrer-Policy header, then that policy is used for requests that
the worker initiates. If no Referrer-Policy header is present, then
the worker gets the default referrer policy.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70

BUG=619228
==========

to

==========
Implement Referrer-Policy header for workers

This CL adds (runtime-enabled) support for the Referrer-Policy header
when loading worker scripts. If a worker script is served with a
Referrer-Policy header, then that policy is used for requests that
the worker initiates. If no Referrer-Policy header is present, then
the worker gets the default referrer policy.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70

BUG=619228

Committed: https://crrev.com/239c8bd69c319553a11b83041042cde6879deaab
Cr-Commit-Position: refs/heads/master@{#401953}
==========

[commit-bot: I haz the power, 2016-06-24 20:25:46]

Patchset 3 (id:??) landed as
https://crrev.com/239c8bd69c319553a11b83041042cde6879deaab
Cr-Commit-Position: refs/heads/master@{#401953}