Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2086143003: Remove invalid UTF-8 characters from test output (Closed)

Created:
4 years, 6 months ago by brendan.kirby
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove invalid UTF-8 characters from test output Occasionally tests output characters that aren't valid unicode UTF-8 characters. This causes the --json-test-results file not to be written. Replace these characters with the UTF-8 invalid character. BUG= Committed: https://crrev.com/0f75d7d3e3f890d86fbb3d7616fbfa469b41ef76 Cr-Commit-Position: refs/heads/master@{#37404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/testrunner/local/commands.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
brendan.kirby
PTAL We're seeing some V8 tests fail that are writing invalid UTF-8 characters in their ...
4 years, 6 months ago (2016-06-23 00:59:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086143003/1
4 years, 6 months ago (2016-06-24 08:10:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 08:34:17 UTC) #6
Michael Achenbach
lgtm - seems legit. A place where this could go wrong is the checked in ...
4 years, 6 months ago (2016-06-24 08:47:37 UTC) #7
Yang
On 2016/06/24 08:47:37, Michael Achenbach wrote: > lgtm - seems legit. A place where this ...
4 years, 5 months ago (2016-06-27 08:00:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2086143003/1
4 years, 5 months ago (2016-06-29 19:48:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 20:32:27 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 20:35:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f75d7d3e3f890d86fbb3d7616fbfa469b41ef76
Cr-Commit-Position: refs/heads/master@{#37404}

Powered by Google App Engine
This is Rietveld 408576698