Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 2086123003: Move KWalletDBus util from the Password Manager to OSCrypt. (Closed)

Created:
4 years, 6 months ago by cfroussios
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, satorux1
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move KWalletDBus util from the Password Manager to OSCrypt. This is part of deprecating the use of OS services for storing passwords with Password Manager. The moved util will be used to create a specialization of KeyStorage for KWallet. BUG=602624 TBR=davidben@chromium.org Committed: https://crrev.com/e5d0dfbd158dad8e3f976fc493a8ea8fcdec29cf Cr-Commit-Position: refs/heads/master@{#401836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1201 lines) Patch
D chrome/browser/password_manager/kwallet_dbus.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/password_manager/kwallet_dbus.cc View 1 chunk +0 lines, -344 lines 0 comments Download
D chrome/browser/password_manager/kwallet_dbus_unittest.cc View 1 chunk +0 lines, -696 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M components/os_crypt.gypi View 2 chunks +36 lines, -14 lines 0 comments Download
M components/os_crypt/BUILD.gn View 4 chunks +42 lines, -16 lines 0 comments Download
M components/os_crypt/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
A + components/os_crypt/kwallet_dbus.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/os_crypt/kwallet_dbus.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/kwallet_dbus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
cfroussios
Hi. Can you review moving this class into OSCrypt? Thanks!
4 years, 5 months ago (2016-06-23 09:01:46 UTC) #3
Lei Zhang
lgtm
4 years, 5 months ago (2016-06-23 20:35:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086123003/1
4 years, 5 months ago (2016-06-23 20:36:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/206148)
4 years, 5 months ago (2016-06-23 20:46:05 UTC) #8
cfroussios
Hi satorux! Could you review this new dependency on dbus? dbus is required to communicate ...
4 years, 5 months ago (2016-06-24 08:44:43 UTC) #10
satorux1
the dependency lgtm
4 years, 5 months ago (2016-06-24 08:50:02 UTC) #11
cfroussios
Hi davidben! I TBRed you for the dependency on crypto. The dependency already existed, but ...
4 years, 5 months ago (2016-06-24 08:59:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086123003/1
4 years, 5 months ago (2016-06-24 09:07:20 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-24 09:11:00 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 09:13:05 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5d0dfbd158dad8e3f976fc493a8ea8fcdec29cf
Cr-Commit-Position: refs/heads/master@{#401836}

Powered by Google App Engine
This is Rietveld 408576698