Chromium Code Reviews| Index: appengine/findit/handlers/build_failure.py |
| diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py |
| index 9b75d58baa75fc41ca96a38be1535ed9ee64d537..506ce0535d49c8df4e6de985f047012ce38b0045 100644 |
| --- a/appengine/findit/handlers/build_failure.py |
| +++ b/appengine/findit/handlers/build_failure.py |
| @@ -275,7 +275,7 @@ class BuildFailure(BaseHandler): |
| # currently logged-in user is an admin, or if it is explicitly requested |
| # with parameter 'debug=1'. |
| return ( |
| - users.is_current_user_admin() or self.request.get('debug') == '1') |
| + users.is_current_user_admin() or self.request.get('debug') == '1') |
|
chanli
2016/06/28 19:31:20
nit: could fit in one line
|
| def _ShowTriageHelpButton(self): |
| return users.is_current_user_admin() |
| @@ -295,8 +295,15 @@ class BuildFailure(BaseHandler): |
| 'analysis_completed': analysis.completed, |
| 'analysis_failed': analysis.failed, |
| 'analysis_correct': analysis.correct, |
| + 'analysis_is_duplicate': analysis.is_duplicate, |
| 'triage_history': _GetTriageHistory(analysis), |
| 'show_triage_help_button': self._ShowTriageHelpButton(), |
| + 'triage_reference_analysis_master_name': |
| + analysis.triage_reference_analysis_master_name, |
| + 'triage_reference_analysis_builder_name': |
| + analysis.triage_reference_analysis_builder_name, |
| + 'triage_reference_analysis_build_number': |
| + analysis.triage_reference_analysis_build_number |
| } |
| @staticmethod |
| @@ -314,7 +321,7 @@ class BuildFailure(BaseHandler): |
| result = try_job.compile_results[-1] |
| try_job_data['status'] = analysis_status.STATUS_TO_DESCRIPTION.get( |
| - try_job.status, 'unknown').lower() |
| + try_job.status, 'unknown').lower() |
| try_job_data['url'] = result.get('url') |
| try_job_data['completed'] = try_job.completed |
| try_job_data['failed'] = try_job.failed |
| @@ -395,13 +402,13 @@ class BuildFailure(BaseHandler): |
| if analysis.failure_type == failure_type.COMPILE: |
| return { |
| - 'template': 'waterfall/compile_failure.html', |
| - 'data': self._PrepareDataForCompileFailure(analysis), |
| + 'template': 'waterfall/compile_failure.html', |
| + 'data': self._PrepareDataForCompileFailure(analysis), |
| } |
| else: |
| return { |
| - 'template': 'build_failure.html', |
| - 'data': self._PrepareDataForTestFailures(analysis, build_info), |
| + 'template': 'build_failure.html', |
| + 'data': self._PrepareDataForTestFailures(analysis, build_info), |
| } |
| def HandlePost(self): # pragma: no cover |