Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1995)

Unified Diff: appengine/findit/templates/build_failure.html

Issue 2086113004: [Findit] Show build analysis references in UI for Findit Cross-platform auto-triage (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@build-matching
Patch Set: Rebased on tip of tree Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/model/wf_analysis.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/templates/build_failure.html
diff --git a/appengine/findit/templates/build_failure.html b/appengine/findit/templates/build_failure.html
index b032c7d24ed177448b1b6354482a990c9db5a59e..3716aa159d6146789c419485d8014f5b3f3dd6a6 100644
--- a/appengine/findit/templates/build_failure.html
+++ b/appengine/findit/templates/build_failure.html
@@ -76,7 +76,9 @@
findit.analysisFailed = '{{analysis_failed}}' == 'True';
findit.builderUrl = 'https://build.chromium.org/p/{{master_name}}/builders/{{builder_name}}';
findit.buildUrl = findit.builderUrl + '/builds/{{build_number}}';
+ findit.triageReferenceAnalysisUrl = '/waterfall/build-failure?url=https://build.chromium.org/p/{{triage_reference_analysis_master_name}}/builders/{{triage_reference_analysis_builder_name}}/builds/{{triage_reference_analysis_build_number}}';
findit.analysisCorrect = '{{analysis_correct}}'; // Possible values: 'None', 'True', or 'False'.
+ findit.analysisIsDuplicate = '{{analysis_is_duplicate}}' == 'True';
findit.showTriageHelpButton = '{{show_triage_help_button}}' == 'True';
findit.showDebugInfo = '{{show_debug_info}}' == 'True';
findit.analysisResult = {{analysis_result | tojson | safe}};
@@ -96,6 +98,10 @@
} else {
alert('Failed to update datastore. Please refresh and try again.');
}
+ {% if show_debug_info %}
+ $('#duplicates_marked').html('Number of matching build analyses that were also triaged: ' + data['num_duplicate_analyses']);
+ $('#duplicate_reference').html('');
+ {% endif %}
}).error(function(xhr) {
// Replace the whole page with errors from server side.
document.body.outerHTML = xhr.responseText;
@@ -442,6 +448,14 @@
$('.thumb-down').addClass('triaged').removeClass('triage');
}
+ {% if show_debug_info %}
+ if (findit.analysisIsDuplicate) {
+ $('#duplicate_reference').html('This analysis was automatically triaged as a duplicate because of another build analysis: ' +
+ '<a href="' + findit.triageReferenceAnalysisUrl + '">{{triage_reference_analysis_master_name}}/' +
+ '{{triage_reference_analysis_builder_name}}/{{triage_reference_analysis_build_number}}</a>');
+ }
+ {% endif %}
+
if (findit.showTriageHelpButton) {
$('#triage_help_button').click(triageHelp);
}
@@ -652,6 +666,10 @@
<div class="triage thumb-up">Correct <img src="https://www.gstatic.com/images/icons/material/system/1x/thumb_up_black_24dp.png"/></div>
<div class="triage thumb-down"><img src="https://www.gstatic.com/images/icons/material/system/1x/thumb_down_black_24dp.png"/> Incorrect</div>
</div>
+ {% if show_debug_info %}
+ <div id="duplicates_marked"></div>
+ <div id="duplicate_reference"></div>
+ {% endif %}
</div>
{% endif %}
{% endif %}
« no previous file with comments | « appengine/findit/model/wf_analysis.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698