[Findit] Show build analysis references in UI for Findit Cross-platform auto-triage

appengine/findit/handlers/test/triage_analysis_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 from datetime import timedelta
 
-from google.appengine.ext import ndb
+from testing_utils import testing

[lijeffrey, 2016/06/27 20:38:22]

I think you can leave this one where it was even though gpylint complains about
it, i think the order we want is general (i.e. datetime), then these third party
ones(not 100% sure), then findit-specific. They should otherwise be alphabetized
within their groups

[josiahk, 2016/06/28 22:59:23]

Kept per conversation.

 import webapp2
 
-from testing_utils import testing
-
 from handlers import triage_analysis
 from model import analysis_status
 from model import result_status
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 
 
 class TriageAnalysisTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/triage-analysis', triage_analysis.TriageAnalysis),
@@ skipping 106 matching lines @@
     self.assertEquals(200, response.status_int)
     self.assertEquals({'success': False}, response.json_body)
 
   def testSuccessfulTriage(self):
     build_url = buildbot.CreateBuildUrl(
         self.master_name, self.builder_name, self.build_number_found)
     response = self.test_app.get(
         '/triage-analysis',
         params={'url': build_url, 'correct': True, 'format': 'json'})
     self.assertEquals(200, response.status_int)
-    self.assertEquals({'success': True}, response.json_body)
+    self.assertEquals(
+        {'success': True, 'num_duplicate_analyses': 0},

[lijeffrey, 2016/06/27 20:38:22]

nit: put each field on a new line, same with the other dicts

i.e.

{
    'success': True,
    'num_duplicate_analyses': 0,
    ...
}

If it's a dict with just 1 entry then all inline is ok too.

[josiahk, 2016/06/28 22:59:23]

Done! Thanks!

+        response.json_body)
 
   def testIncompleteTriage(self):
     build_url = buildbot.CreateBuildUrl(
         self.master_name, self.builder_name, self.build_number_incomplete)
     response = self.test_app.get(
         '/triage-analysis',
         params={'url': build_url, 'correct': True, 'format': 'json'})
     self.assertEquals(200, response.status_int)
-    self.assertEquals({'success': False}, response.json_body)
+    self.assertEquals(
+        {'success': False, 'num_duplicate_analyses': 0},
+        response.json_body)
+
+  def testDuplicatePropertyWorksWhenNotDuplicate(self):

[lijeffrey, 2016/06/27 20:38:22]

nit: you can name this

testDuplicatePropertyNoDuplicates(self):
  ...

no need for the word "works" in the test since that's what a test does (makes
sure it works!)

same with the other test

[josiahk, 2016/06/28 22:59:23]

Thanks!

+    analysis = WfAnalysis.Get(
+        self.master_name, self.builder_name, self.build_number_found)
+    self.assertFalse(analysis.is_duplicate)
+
+  def testDuplicatePropertyWorksWhenDuplicate(self):
+    analysis = WfAnalysis.Get(
+        self.master_name, self.builder_name, self.build_number_found)
+    analysis.result_status = result_status.FOUND_CORRECT_DUPLICATE
+    self.assertTrue(analysis.is_duplicate)
 
   def testAnalysesMatch(self):
     analysis_with_empty_failures = WfAnalysis.Create(
         self.master_name, self.builder_name, 200)
     analysis_with_empty_failures.result = {
         'failures': []
     }
     analysis_with_empty_failures.put()
 
     analysis_with_no_suspected_cls = WfAnalysis.Create(
@@ skipping 198 matching lines @@
     self.assertFalse(triage_analysis._DoAnalysesMatch(
         analysis_with_tests_1,
         analysis_with_tests_2))
 
   def _createAnalysis(self, build_number, build_start_time):
     analysis = WfAnalysis.Create(
         self.master_name, self.builder_name, build_number)
     analysis.result = {
         'failures': [
             {
-                'suspected_cls': [
-                    {
-                        'revision': 'abc',
-                    }
-                ],
+                'suspected_cls': self.suspected_cls,
                 'step_name': 'step_4',
             }
         ]
     }
     analysis.result_status = result_status.FOUND_UNTRIAGED
     analysis.build_start_time = build_start_time
     analysis.status = analysis_status.COMPLETED
+    analysis.suspected_cls = self.suspected_cls
     analysis.put()
     return analysis
 
   def testGetDuplicateAnalysesTooEarly(self):
     # Two days ago, UTC Noon.
     original_time = (datetime.utcnow() - timedelta(days=2)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(300, original_time)
 
     # An earlier time, outside bounds.
@@ skipping 51 matching lines @@
     original_time = (datetime.utcnow() + timedelta(days=1)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(308, original_time)
 
     # Create another analysis at the same time (also tomorrow).
     self._createAnalysis(309, original_time)
 
     self.assertEquals(
         len(triage_analysis._GetDuplicateAnalyses(analysis_original)), 0)
 
-  def testTriageDuplicateResults(self):
+  def testTriageDuplicateResultsFoundCorrectDuplicate(self):
     # Two days ago, UTC Noon.
     original_time = (datetime.utcnow() - timedelta(days=2)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(310, original_time)
 
     # Create another analysis at the same time (also two days ago).
     self._createAnalysis(311, original_time)
 
-    triage_analysis._TriageDuplicateResults(analysis_original, True)
+    triage_analysis._TriageDuplicateResults(analysis_original, is_correct=True)
 
     second_analysis = WfAnalysis.Get(self.master_name, self.builder_name, 311)
 
-    self.assertEquals(result_status.NOT_FOUND_CORRECT,
+    self.assertEquals(result_status.FOUND_CORRECT_DUPLICATE,
                       second_analysis.result_status)
 
+  def testTriageDuplicateResultsFoundIncorrectDuplicate(self):
+    # Two days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=2)).replace(
+        hour=12, minute=0, second=0, microsecond=0)
+    analysis_original = self._createAnalysis(312, original_time)
+
+    # Create another analysis at the same time (also two days ago).
+    self._createAnalysis(313, original_time)

[lijeffrey, 2016/06/27 20:38:22]

why not make the second analysis a slightly later time, since that's the more
likely scenario?

[josiahk, 2016/06/28 22:59:23]

Done!

+
+    triage_analysis._TriageDuplicateResults(analysis_original, is_correct=False)
+
+    second_analysis = WfAnalysis.Get(self.master_name, self.builder_name, 313)
+
+    self.assertEquals(result_status.FOUND_INCORRECT_DUPLICATE,
+                      second_analysis.result_status)