[Findit] Show build analysis references in UI for Findit Cross-platform auto-triage

appengine/findit/handlers/test/triage_analysis_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 from datetime import timedelta
 
-from google.appengine.ext import ndb
+from testing_utils import testing
 import webapp2
 
-from testing_utils import testing
-
 from handlers import triage_analysis
 from model import analysis_status
 from model import result_status
 from model.wf_analysis import WfAnalysis
 from waterfall import buildbot
 
 
 class TriageAnalysisTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/triage-analysis', triage_analysis.TriageAnalysis),
   ], debug=True)
 
   def setUp(self):
     super(TriageAnalysisTest, self).setUp()
     self.master_name = 'm'
     self.builder_name = 'b'
     self.build_number_incomplete = 120  # Analysis is not completed yet.
     self.build_number_found = 122  # Suspected CLs are found for this build.
     self.build_number_not_found = 123  # No suspected CLs found.
     self.suspected_cls = [{
         'repo_name': 'chromium',
         'revision': 'r1',
         'commit_position': 123,
         'url': 'https://codereview.chromium.org/123',
     }]
 
-    self.build_start_time = (datetime.utcnow() - timedelta(2)).replace(
-        hour=12, minute=0, second=0, microsecond=0)  # Two days ago, UTC Noon.
+    self.build_start_time = (datetime.utcnow() - timedelta(3)).replace(
+        hour=12, minute=0, second=0, microsecond=0)  # Three days ago, UTC Noon.
 
     analysis = WfAnalysis.Create(
         self.master_name, self.builder_name, self.build_number_incomplete)
     analysis.status = analysis_status.RUNNING
     analysis.put()
 
     analysis = WfAnalysis.Create(
         self.master_name, self.builder_name, self.build_number_found)
     analysis.status = analysis_status.COMPLETED
     analysis.suspected_cls = self.suspected_cls
@@ skipping 67 matching lines @@
     self.assertEquals(2, len(analysis.triage_history))
     self.assertEquals(result_status.FOUND_CORRECT,
                       analysis.triage_history[0]['result_status'])
     self.assertEquals(result_status.FOUND_INCORRECT,
                       analysis.triage_history[1]['result_status'])
 
   def testInvalidBuildUrl(self):
     build_url = 'http://invalid/build/url'
     response = self.test_app.get(
         '/triage-analysis',
-        params={'url': build_url, 'correct': True, 'format': 'json'})
+        params={
+            'url': build_url,
+            'correct': True,
+            'format': 'json'
+        })
     self.assertEquals(200, response.status_int)
     self.assertEquals({'success': False}, response.json_body)
 
   def testSuccessfulTriage(self):
     build_url = buildbot.CreateBuildUrl(
         self.master_name, self.builder_name, self.build_number_found)
     response = self.test_app.get(
         '/triage-analysis',
-        params={'url': build_url, 'correct': True, 'format': 'json'})
+        params={
+            'url': build_url,
+            'correct': True,
+            'format': 'json'
+        })
     self.assertEquals(200, response.status_int)
-    self.assertEquals({'success': True}, response.json_body)
+    self.assertEquals(
+        {
+            'success': True,
+            'num_duplicate_analyses': 0
+        },
+        response.json_body)
 
   def testIncompleteTriage(self):
     build_url = buildbot.CreateBuildUrl(
         self.master_name, self.builder_name, self.build_number_incomplete)
     response = self.test_app.get(
         '/triage-analysis',
-        params={'url': build_url, 'correct': True, 'format': 'json'})
+        params={
+            'url': build_url,
+            'correct': True,
+            'format': 'json'
+        })
     self.assertEquals(200, response.status_int)
-    self.assertEquals({'success': False}, response.json_body)
+    self.assertEquals(
+        {
+            'success': False,
+            'num_duplicate_analyses': 0
+        },
+        response.json_body)
 
   def testAnalysesMatch(self):
     analysis_with_empty_failures = WfAnalysis.Create(
         self.master_name, self.builder_name, 200)
     analysis_with_empty_failures.result = {
         'failures': []
     }
     analysis_with_empty_failures.put()
 
     analysis_with_no_suspected_cls = WfAnalysis.Create(
@@ skipping 198 matching lines @@
     self.assertFalse(triage_analysis._DoAnalysesMatch(
         analysis_with_tests_1,
         analysis_with_tests_2))
 
   def _createAnalysis(self, build_number, build_start_time):
     analysis = WfAnalysis.Create(
         self.master_name, self.builder_name, build_number)
     analysis.result = {
         'failures': [
             {
-                'suspected_cls': [
-                    {
-                        'revision': 'abc',
-                    }
-                ],
+                'suspected_cls': self.suspected_cls,
                 'step_name': 'step_4',
             }
         ]
     }
     analysis.result_status = result_status.FOUND_UNTRIAGED
     analysis.build_start_time = build_start_time
     analysis.status = analysis_status.COMPLETED
+    analysis.suspected_cls = self.suspected_cls
     analysis.put()
     return analysis
 
   def testGetDuplicateAnalysesTooEarly(self):
-    # Two days ago, UTC Noon.
-    original_time = (datetime.utcnow() - timedelta(days=2)).replace(
+    # Three days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=3)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(300, original_time)
 
     # An earlier time, outside bounds.
     too_early_time = (original_time - timedelta(
         hours=triage_analysis.MATCHING_ANALYSIS_HOURS_AGO_START*2))
     self._createAnalysis(301, too_early_time)
 
     self.assertEquals(
         len(triage_analysis._GetDuplicateAnalyses(analysis_original)), 0)
 
   def testGetDuplicateAnalysesEarlier(self):
-    # Two days ago, UTC Noon.
-    original_time = (datetime.utcnow() - timedelta(days=2)).replace(
+    # Three days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=3)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(302, original_time)
 
     # An earlier time, within bounds.
     earlier_time = (original_time - timedelta(
         hours=triage_analysis.MATCHING_ANALYSIS_HOURS_AGO_START/2))
     self._createAnalysis(303, earlier_time)
 
     self.assertEquals(
         len(triage_analysis._GetDuplicateAnalyses(analysis_original)), 1)
 
   def testGetDuplicateAnalysesLater(self):
-    # Two days ago, UTC Noon.
-    original_time = (datetime.utcnow() - timedelta(days=2)).replace(
+    # Three days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=3)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(304, original_time)
 
     # A later time, within bounds.
     later_time = (original_time + timedelta(
         hours=triage_analysis.MATCHING_ANALYSIS_HOURS_AGO_START/2))
     self._createAnalysis(305, later_time)
 
     self.assertEquals(
         len(triage_analysis._GetDuplicateAnalyses(analysis_original)), 1)
 
   def testGetDuplicateAnalysesTooLate(self):
-    # Two days ago, UTC Noon.
-    original_time = (datetime.utcnow() - timedelta(days=2)).replace(
+    # Three days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=3)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(306, original_time)
 
     # A later time, outside bounds.
     too_late_time = (original_time + timedelta(
         hours=triage_analysis.MATCHING_ANALYSIS_HOURS_AGO_START*2))
     self._createAnalysis(307, too_late_time)
 
     self.assertEquals(
         len(triage_analysis._GetDuplicateAnalyses(analysis_original)), 0)
 
-  def testGetDuplicateAnalysesNotToday(self):
+  def testGetDuplicateAnalysesPastEndBoundTime(self):
     # Tomorrow, UTC Noon.
     original_time = (datetime.utcnow() + timedelta(days=1)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(308, original_time)
 
     # Create another analysis at the same time (also tomorrow).
     self._createAnalysis(309, original_time)
 
     self.assertEquals(
         len(triage_analysis._GetDuplicateAnalyses(analysis_original)), 0)
 
-  def testTriageDuplicateResults(self):
-    # Two days ago, UTC Noon.
-    original_time = (datetime.utcnow() - timedelta(days=2)).replace(
+  def testTriageDuplicateResultsFoundCorrectDuplicate(self):
+    # Three days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=3)).replace(
         hour=12, minute=0, second=0, microsecond=0)
     analysis_original = self._createAnalysis(310, original_time)
 
-    # Create another analysis at the same time (also two days ago).
-    self._createAnalysis(311, original_time)
+    # Create another analysis a bit later (also three days ago).
+    self._createAnalysis(311, original_time + timedelta(minutes=1))
 
-    triage_analysis._TriageDuplicateResults(analysis_original, True)
+    triage_analysis._TriageAndCountDuplicateResults(analysis_original,
+                                                    is_correct=True)
 
     second_analysis = WfAnalysis.Get(self.master_name, self.builder_name, 311)
 
-    self.assertEquals(result_status.NOT_FOUND_CORRECT,
+    self.assertEquals(result_status.FOUND_CORRECT_DUPLICATE,
                       second_analysis.result_status)
 
+  def testTriageDuplicateResultsFoundIncorrectDuplicate(self):
+    # Three days ago, UTC Noon.
+    original_time = (datetime.utcnow() - timedelta(days=3)).replace(
+        hour=12, minute=0, second=0, microsecond=0)
+    analysis_original = self._createAnalysis(312, original_time)
+
+    # Create another analysis a bit later (also three days ago).
+    self._createAnalysis(313, original_time + timedelta(minutes=1))
+
+    triage_analysis._TriageAndCountDuplicateResults(analysis_original,
+                                                    is_correct=False)
+
+    second_analysis = WfAnalysis.Get(self.master_name, self.builder_name, 313)
+
+    self.assertEquals(result_status.FOUND_INCORRECT_DUPLICATE,
+                      second_analysis.result_status)