[Findit] Show build analysis references in UI for Findit Cross-platform auto-triage

appengine/findit/model/wf_analysis.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.ext import ndb
 
 from common import constants
 from common.waterfall import failure_type
 from model.base_build_model import BaseBuildModel
 from model import analysis_status
@@ skipping 64 matching lines @@
       return True
 
     if self.result_status in (
         result_status.FOUND_INCORRECT,
         result_status.NOT_FOUND_INCORRECT,
         result_status.FOUND_INCORRECT_DUPLICATE):
       return False
 
     return None
 
+  @property
+  def duplicate(self):
+    """Returns whether the analysis result is a duplicate or not.
+
+    Returns:
+      True: duplicate
+      False: not a duplicate
+    """
+
+    if self.result_status in (
+        result_status.FOUND_CORRECT_DUPLICATE,
+        result_status.FOUND_INCORRECT_DUPLICATE):
+      return True
+
+    return False

[chanli, 2016/06/24 18:24:20]

Nit: you can also use:

return True if self.result_status in
(result_status.FOUND_CORRECT_DUPLICATE,result_status.FOUND_INCORRECT_DUPLICATE)
else False

[josiahk, 2016/06/27 19:33:25]

Done.

+
   def Reset(self):  # pragma: no cover
     """Resets to the state as if no analysis is run."""
     self.pipeline_status_path = None
     self.status = analysis_status.PENDING
     self.request_time = None
     self.start_time = None
     self.end_time = None
 
   @property
   def failure_type(self):
@@ skipping 51 matching lines @@
   suspected_cls = ndb.JsonProperty(indexed=False, compressed=True)
   # Record the id of try job results of each failure.
   failure_result_map = ndb.JsonProperty(indexed=False, compressed=True)
 
   # The actual culprit CLs that are responsible for the failures.
   culprit_cls = ndb.JsonProperty(indexed=False, compressed=True)
   # Conclusion of analysis result for the build failure: 'Found' or 'Not Found'.
   result_status = ndb.IntegerProperty(indexed=True)
   # Record the history of triage.
   triage_history = ndb.JsonProperty(indexed=False, compressed=True)
+  # An optional reference to the analysis that might have caused this analysis
+  # to be marked as a duplicate.
+  # triage_reference_analysis_key = ndb.StringProperty(indexed=False)

[chanli, 2016/06/24 18:24:20]

If you don't need this anymore, please remove it.

[josiahk, 2016/06/27 19:33:25]

Done.

+  triage_reference_analysis_master_name = ndb.StringProperty(indexed=False)
+  triage_reference_analysis_builder_name = ndb.StringProperty(indexed=False)
+  triage_reference_analysis_build_number = ndb.IntegerProperty(indexed=False)