[Findit] Show build analysis references in UI for Findit Cross-platform auto-triage

appengine/findit/common/base_handler.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import json
 import logging
 import os
 
 from google.appengine.api import users
 import jinja2
 import webapp2
 
 from common import constants
 
 
 JINJA_ENVIRONMENT = jinja2.Environment(
     loader=jinja2.FileSystemLoader(constants.HTML_TEMPLATE_DIR),
     extensions=['jinja2.ext.autoescape'],
     autoescape=True)
 
 
 def ToJson(data):
   return json.dumps(data, sort_keys=True)  # Sort by key to keep order on UI.
 
-

[chanli, 2016/06/24 18:24:20]

This two lines should not be deleted.

[josiahk, 2016/06/27 19:33:25]

Done.

[lijeffrey, 2016/06/27 20:38:22]

I think gpylin will complain if there aren't 2 lines but I could be wrong (and
it in fact complained there were 2 lines here), be sure to run gpylint <path to
your .py> before submitting a patch for review

[josiahk, 2016/06/28 22:59:23]

Fixed. Thanks!

 JINJA_ENVIRONMENT.filters['tojson'] = ToJson
 
-

[lijeffrey, 2016/06/27 20:38:22]

It also doesn't seem like there are any functional changes to this module so you
may want to revert this file before submitting

 class Permission(object):
   ADMIN = 0
   CORP_USER = 8
   ANYONE = 16
 
 
 class BaseHandler(webapp2.RequestHandler):
   # By default, set permission level to ADMIN only.
   # Subclass needs to overwrite it explicitly to give wider access.
   PERMISSION_LEVEL = Permission.ADMIN
@@ skipping 138 matching lines @@
       return_code = 500
       cache_expiry = None
 
     self._SendResponse(template, data, return_code, cache_expiry)
 
   def get(self):
     self._Handle(self.HandleGet)
 
   def post(self):
     self._Handle(self.HandlePost)