service worker: Add net_log for fetch event dispatch

service worker: Add net_log for fetch event dispatch

Many interesting things happen in ServiceWorkerFetchDispatcher. Add logging for easier
debugging when something goes wrong.

BUG=622963
Committed: https://crrev.com/65cb8ce1797fa6131ac787377d8acfb94aa3d370
Cr-Commit-Position: refs/heads/master@{#402105}

[falken, 2016-06-24 03:27:16]

Description was changed from

==========
WIP net log

BUG=
==========

to

==========
service worker: Add net_log for fetch event dispatch

Many interesting things happen in ServiceWorkerFetchDispatcher. Add logging for
easier
debugging when something goes wrong.

BUG=622963
==========

[falken, 2016-06-24 03:27:16]

falken@chromium.org changed reviewers:
+ horo@chromium.org

[falken, 2016-06-24 03:28:16]

PTAL

[falken, 2016-06-24 11:25:27]

falken@chromium.org changed reviewers:
+ mattm@chromium.org

[falken, 2016-06-24 11:25:28]

+mattm for net/ OWNER review

[eroman, 2016-06-24 18:34:46]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2016-06-24 18:34:46]

//net LGTM.

As an aside, we do need to pull serviceworker events out of //net in the future
(crbug.com/90674)

[horo, 2016-06-25 05:49:56]

lgtm with a nit

https://codereview.chromium.org/2086093004/diff/60001/content/browser/service...
File content/browser/service_worker/service_worker_fetch_dispatcher.cc (right):

https://codereview.chromium.org/2086093004/diff/60001/content/browser/service...
content/browser/service_worker/service_worker_fetch_dispatcher.cc:81:
std::string event_type =
nit:
const char*
or directly call in net::NetLog::StringCallback

[falken, 2016-06-27 01:19:17]

https://codereview.chromium.org/2086093004/diff/60001/content/browser/service...
File content/browser/service_worker/service_worker_fetch_dispatcher.cc (right):

https://codereview.chromium.org/2086093004/diff/60001/content/browser/service...
content/browser/service_worker/service_worker_fetch_dispatcher.cc:81:
std::string event_type =
On 2016/06/25 05:49:56, horo wrote:
> nit:
> const char*
> or directly call in net::NetLog::StringCallback

Done.

[falken, 2016-06-27 01:19:46]

The CQ bit was checked by falken@chromium.org

[falken, 2016-06-27 01:19:46]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org,
eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2086093004/#ps100001
(title: "use eventtypetyostring directly")

[commit-bot: I haz the power, 2016-06-27 01:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 03:19:56]

Description was changed from

==========
service worker: Add net_log for fetch event dispatch

Many interesting things happen in ServiceWorkerFetchDispatcher. Add logging for
easier
debugging when something goes wrong.

BUG=622963
==========

to

==========
service worker: Add net_log for fetch event dispatch

Many interesting things happen in ServiceWorkerFetchDispatcher. Add logging for
easier
debugging when something goes wrong.

BUG=622963
==========

[commit-bot: I haz the power, 2016-06-27 03:19:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-27 03:21:39]

Description was changed from

==========
service worker: Add net_log for fetch event dispatch

Many interesting things happen in ServiceWorkerFetchDispatcher. Add logging for
easier
debugging when something goes wrong.

BUG=622963
==========

to

==========
service worker: Add net_log for fetch event dispatch

Many interesting things happen in ServiceWorkerFetchDispatcher. Add logging for
easier
debugging when something goes wrong.

BUG=622963

Committed: https://crrev.com/65cb8ce1797fa6131ac787377d8acfb94aa3d370
Cr-Commit-Position: refs/heads/master@{#402105}
==========

[commit-bot: I haz the power, 2016-06-27 03:21:40]

Patchset 6 (id:??) landed as
https://crrev.com/65cb8ce1797fa6131ac787377d8acfb94aa3d370
Cr-Commit-Position: refs/heads/master@{#402105}