Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2086093003: Remove calls to deprecated MessageLoop methods in ui. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in ui. This CL makes the following replacements in ui: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=thakis@chromium.org Committed: https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94 Cr-Commit-Position: refs/heads/master@{#401372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M ui/events/gesture_detection/gesture_provider_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/events/platform/platform_event_source_unittest.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M ui/gfx/animation/animation_container_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/animation/animation_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M ui/views/animation/bounds_animator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:44:29 UTC) #1
Nico
rs-lgtm
4 years, 6 months ago (2016-06-22 18:23:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086093003/1
4 years, 6 months ago (2016-06-22 18:43:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 18:50:46 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:58:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/726c9d64f8f41c2755300409cf6e8c4918651f94
Cr-Commit-Position: refs/heads/master@{#401372}

Powered by Google App Engine
This is Rietveld 408576698