Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2086083002: Fix percentage handling for replaced elements (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 6 months ago
Reviewers:
eae, dgrogran
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix percentage handling for replaced elements - LayoutBox::computeReplacedLogicalHeightUsing needs to take into account the flexbox definite-height cases - LayoutBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight needs to also call addPercentHeightDescendant so it can get relaid out appropriately BUG=499766 TEST=css3/flexbox/percentage-height-replaced-element.html Committed: https://crrev.com/c8c940b4f47e9c12edd9d1f1887c235ea45b5c27 Cr-Commit-Position: refs/heads/master@{#401417}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : with test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/percentage-height-replaced-element.html View 1 2 3 1 chunk +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
cbiesinger
4 years, 6 months ago (2016-06-22 19:59:21 UTC) #3
eae
OK, please add a TEST=css3/flexbox/percentage-height-replaced-element.html like to the CL description. LGTM
4 years, 6 months ago (2016-06-22 20:05:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086083002/60001
4 years, 6 months ago (2016-06-22 20:10:16 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-22 21:48:35 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:51:55 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c8c940b4f47e9c12edd9d1f1887c235ea45b5c27
Cr-Commit-Position: refs/heads/master@{#401417}

Powered by Google App Engine
This is Rietveld 408576698