Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2085993003: Android: Don't systematically move GSA to the foreground cgroup. (Closed)

Created:
4 years, 6 months ago by Benoit L
Modified:
4 years, 6 months ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Don't systematically move GSA to the foreground cgroup. Chrome binds to a GSA service in onStartWithNative(). By default, this moves GSA to the foreground cgroup, which is not what we want. Add the required bind flag to prevent this. See https://developer.android.com/reference/android/content/Context.html#BIND_NOT_FOREGROUND. BUG=614388 Committed: https://crrev.com/c2ccc5b47944725186cce4af5f51111c25fbedde Cr-Commit-Position: refs/heads/master@{#401233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Benoit L
4 years, 6 months ago (2016-06-21 15:27:03 UTC) #2
Ted C
lgtm
4 years, 6 months ago (2016-06-21 20:03:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085993003/1
4 years, 6 months ago (2016-06-22 08:08:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 08:49:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 08:51:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2ccc5b47944725186cce4af5f51111c25fbedde
Cr-Commit-Position: refs/heads/master@{#401233}

Powered by Google App Engine
This is Rietveld 408576698