Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2085973004: Color: Remove ViewMsg_ColorProfile (Closed)

Created:
4 years, 6 months ago by ccameron
Modified:
4 years, 6 months ago
CC:
anandc+watch-blimp_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, jessicag+watch-blimp_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, nyquist+watch-blimp_chromium.org, piman+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Color: Remove ViewMsg_ColorProfile This is not used yet. When it is ready to be used, it will be rolled into the same IPC that updates the other screen properties. BUG=622133 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e Cr-Commit-Position: refs/heads/master@{#401770}

Patch Set 1 #

Patch Set 2 : Leave widget part for now #

Patch Set 3 : Don't change profile yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -138 lines) Patch
M blimp/engine/feature/engine_render_widget_feature_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 5 chunks +0 lines, -53 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
ccameron
ptal Adding enne@ for color stuff Adding sievers@ for content/ stamp Adding wez@ for blimp/ ...
4 years, 6 months ago (2016-06-22 00:45:47 UTC) #5
Wez
nit: Is there a bug # tracking this work, to mention in the BUG= line?
4 years, 6 months ago (2016-06-22 00:46:59 UTC) #6
Wez
blimp/ LGTM
4 years, 6 months ago (2016-06-22 00:47:13 UTC) #7
enne (OOO)
lgtm
4 years, 6 months ago (2016-06-22 21:14:48 UTC) #10
ccameron
Adding dcheng@ for view_messages.h (just deleting a not-yet-used IPC). Ping sievers@ again for content/ stamp.
4 years, 6 months ago (2016-06-23 18:16:31 UTC) #12
dcheng
rs lgtm
4 years, 6 months ago (2016-06-23 18:26:49 UTC) #13
no sievers
> it will be rolled into the same IPC that updates the other screen properties. ...
4 years, 6 months ago (2016-06-23 23:43:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085973004/40001
4 years, 6 months ago (2016-06-23 23:44:37 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-24 01:23:52 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 01:25:10 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/29736bc1123b16d24716cd8d8f62bc2174a0746e
Cr-Commit-Position: refs/heads/master@{#401770}

Powered by Google App Engine
This is Rietveld 408576698