scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json - Issue 2085953004: Revert of V8: Switch windows bots to mb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json

Issue 2085953004: Revert of V8: Switch windows bots to mb (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json

index a35b194dd64f6086bdd500efaf03cb774c8d60ed..9da9ce327083a43c01142ce15264cd18a79f29de 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json

@@ -128,7 +128,6 @@

"cwd": "[SLAVE_BUILD]\\v8",

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json",

- "GYP_CHROMIUM_NO_ACTION": "1",

"GYP_DEFINES": "clang=1 gomadir='[CACHE]\\cipd\\goma' target_arch=x64 use_goma=1 v8_target_arch=x64",

"GYP_GENERATORS": "ninja",

"PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools]"

@@ -145,42 +144,6 @@

"RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\cleanup_temp.py"

"name": "cleanup_temp"

- },

- {

- "cmd": [

- "python",

- "-u",

- "[SLAVE_BUILD]\\v8\\tools\\mb\\mb.py",

- "gen",

- "-m",

- "client.v8",

- "-b",

- "V8 Win64 - clang",

- "--config-file",

- "[SLAVE_BUILD]\\v8\\infra\\mb\\mb_config.pyl",

- "--goma-dir",

- "[CACHE]\\cipd\\goma",

- "--gyp-script=gypfiles\\gyp_v8",

- "//out/Release_x64"

- ],

- "env": {

- "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"

- },

- "name": "generate_build_files",

- "stdout": "/path/to/tmp/",

- "~followup_annotations": [

- "@@@STEP_LOG_LINE@stdout@some line@@@",

- "@@@STEP_LOG_LINE@stdout@GYP_DEFINES='target_arch=x64 cool_flag=a=1'@@@",

- "@@@STEP_LOG_LINE@stdout@moar@@@",

- "@@@STEP_LOG_END@stdout@@@",

- "@@@STEP_LOG_LINE@diff@+ cool_flag: a=1@@@",

- "@@@STEP_LOG_LINE@diff@- clang: 1@@@",

- "@@@STEP_LOG_LINE@diff@- gomadir: '[CACHE]\\cipd\\goma'@@@",

- "@@@STEP_LOG_LINE@diff@ target_arch: x64@@@",

- "@@@STEP_LOG_LINE@diff@- use_goma: 1@@@",

- "@@@STEP_LOG_END@diff@@@",

- "@@@STEP_WARNINGS@@@"

- ]

{

"allow_subannotations": true,