Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 208593002: DevTools: fix CSS parser to properly report last parsed chunk (Closed)

Created:
6 years, 9 months ago by lushnikov
Modified:
6 years, 9 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix CSS parser to property report last parsed chunk This patch fixes CSSParser which failed to properly report last parsed chunk. BUG=329825 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M Source/devtools/front_end/CSSParser.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ScriptFormatterWorker.js View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
Please take a look
6 years, 9 months ago (2014-03-21 17:09:04 UTC) #1
apavlov
lgtm
6 years, 9 months ago (2014-03-24 08:01:27 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-24 08:01:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/208593002/1
6 years, 9 months ago (2014-03-24 08:01:39 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 08:57:51 UTC) #5
Message was sent while issue was closed.
Change committed as 169836

Powered by Google App Engine
This is Rietveld 408576698