[heap] Internalize kExternalAllocationLimit

[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=chromium:621829
LOG=N

Committed: https://crrev.com/706b3f2730729f80686ad4a3228b860a13627afd
Cr-Commit-Position: refs/heads/master@{#37131}

[Michael Lippautz, 2016-06-21 07:36:25]

Description was changed from

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

BUG=
==========

to

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

BUG=
==========

[Michael Lippautz, 2016-06-21 07:41:43]

mlippautz@chromium.org changed reviewers:
+ jochen@chromium.org

[Michael Lippautz, 2016-06-21 07:41:44]

wdyt? this way we can easily start playing with more dynamic external alloc
limits.

https://codereview.chromium.org/2085893002/diff/20001/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/2085893002/diff/20001/include/v8.h#oldcode8721
include/v8.h:8721: *amount_of_external_allocated_memory = amount;
Moving this line above the branch should be the only behavior change. Since we
could potentially do emergency GCs, I think we should update the value before
continuing.

[Michael Lippautz, 2016-06-21 07:41:58]

Description was changed from

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

BUG=
==========

to

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=
==========

[jochen (gone - plz use gerrit), 2016-06-21 07:44:14]

lgtm

[Michael Lippautz, 2016-06-21 07:55:51]

Description was changed from

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=
==========

to

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=chromium:621829
LOG=N
==========

[Michael Lippautz, 2016-06-21 07:58:10]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 07:58:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085893002/20001

[Michael Lippautz, 2016-06-21 07:58:22]

On 2016/06/21 07:44:14, jochen wrote:
> lgtm

fyi: added a tracking bug

[commit-bot: I haz the power, 2016-06-21 08:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 08:15:51]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Lippautz, 2016-06-21 08:18:26]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 08:18:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085893002/40001

[commit-bot: I haz the power, 2016-06-21 08:45:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 08:45:59]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-06-21 09:22:51]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-06-21 09:22:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2085893002/#ps40001
(title: "Initialize limit")

[commit-bot: I haz the power, 2016-06-21 09:22:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085893002/40001

[commit-bot: I haz the power, 2016-06-21 09:25:17]

Description was changed from

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=chromium:621829
LOG=N
==========

to

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=chromium:621829
LOG=N
==========

[commit-bot: I haz the power, 2016-06-21 09:25:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-21 09:27:04]

Description was changed from

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=chromium:621829
LOG=N
==========

to

==========
[heap] Internalize kExternalAllocationLimit

Base the fast-path in AdjustAmountOfExternalMemory on a value + limit. To
preserve the behavior the limit is just set using kExternalAllocationLimit.

Redo naming of related members.

R=jochen@chromium.org
BUG=chromium:621829
LOG=N

Committed: https://crrev.com/706b3f2730729f80686ad4a3228b860a13627afd
Cr-Commit-Position: refs/heads/master@{#37131}
==========

[commit-bot: I haz the power, 2016-06-21 09:27:05]

Patchset 3 (id:??) landed as
https://crrev.com/706b3f2730729f80686ad4a3228b860a13627afd
Cr-Commit-Position: refs/heads/master@{#37131}