Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2085883002: Revert of Provide v8 dependency on tracing. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Provide v8 dependency on tracing. (patchset #2 id:20001 of https://codereview.chromium.org/2068073002/ ) Reason for revert: Feature not needed. Original issue's description: > Provide v8 dependency on tracing. > > Related to https://codereview.chromium.org/2061933002/. When > that CL lands, the variable introduced by the present CL would provide > the root for the path to the tracing includes, in the context of the > chromium build. > > BUG= > > Committed: https://crrev.com/6d4418ff859750f445af6e4612a5665ae2f84837 > Cr-Commit-Position: refs/heads/master@{#400355} TBR=fmeawad@chromium.org,dpranke@chromium.org,mtrofin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Provide v8 dependency on tracing.
4 years, 6 months ago (2016-06-21 06:46:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085883002/1
4 years, 6 months ago (2016-06-21 06:46:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/203943)
4 years, 6 months ago (2016-06-21 06:53:16 UTC) #5
Michael Achenbach
I assume you reverted this already in a different CL?
4 years, 6 months ago (2016-06-21 07:55:40 UTC) #6
Mircea Trofin
4 years, 6 months ago (2016-06-21 13:23:13 UTC) #7
On 2016/06/21 07:55:40, Michael Achenbach wrote:
> I assume you reverted this already in a different CL?

Yes, https://codereview.chromium.org/2072133003/

Powered by Google App Engine
This is Rietveld 408576698