third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp - Issue 2085873004: Send scroll animation takeOver message in the same frame that it's created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

Issue 2085873004: Send scroll animation takeOver message in the same frame that it's created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix DCHECK Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp ('K') | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

index 976a456e9e33db9bf47cdd81cfa1c5b35f723157..1a8fb974ba18712e52eb7276db458f7797a3324b 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

@@ -586,8 +586,6 @@ TEST(ScrollAnimatorTest, ImplOnlyAnimationUpdatesCleared)

// Verify that the takeover update is cleared.

animator->takeOverImplOnlyScrollOffsetAnimation();

- EXPECT_TRUE(animator->hasAnimationThatRequiresService());

- animator->updateCompositorAnimations();

EXPECT_FALSE(animator->hasAnimationThatRequiresService());

// Forced GC in order to finalize objects depending on the mock object.