Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 208583007: Tunnel the CDD from the Print Preview javascript to the privet operation (Closed)

Created:
6 years, 9 months ago by Noam Samuel
Modified:
6 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Tunnel the CDD from the Print Preview javascript to the privet operation Take the CDD from the print preview javascript and put it in the PrivetLocalPrintOperation. BUG=354605 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258784

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -28 lines) Patch
M chrome/browser/local_discovery/privet_http.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 3 chunks +6 lines, -1 line 2 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 11 chunks +46 lines, -12 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Noam Samuel
6 years, 9 months ago (2014-03-21 22:28:17 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/208583007/diff/1/chrome/browser/local_discovery/privet_http_impl.h File chrome/browser/local_discovery/privet_http_impl.h (right): https://codereview.chromium.org/208583007/diff/1/chrome/browser/local_discovery/privet_http_impl.h#newcode260 chrome/browser/local_discovery/privet_http_impl.h:260: cloud_devices::CloudDeviceDescription ticket_; store as strings
6 years, 9 months ago (2014-03-21 22:43:34 UTC) #2
Noam Samuel
https://codereview.chromium.org/208583007/diff/1/chrome/browser/local_discovery/privet_http_impl.h File chrome/browser/local_discovery/privet_http_impl.h (right): https://codereview.chromium.org/208583007/diff/1/chrome/browser/local_discovery/privet_http_impl.h#newcode260 chrome/browser/local_discovery/privet_http_impl.h:260: cloud_devices::CloudDeviceDescription ticket_; On 2014/03/21 22:43:34, Vitaly Buka wrote: > ...
6 years, 9 months ago (2014-03-21 23:06:29 UTC) #3
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-21 23:06:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/208583007/1
6 years, 9 months ago (2014-03-21 23:06:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 23:22:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-21 23:22:19 UTC) #7
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-21 23:29:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/208583007/1
6 years, 9 months ago (2014-03-21 23:30:26 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 04:58:43 UTC) #10
Message was sent while issue was closed.
Change committed as 258784

Powered by Google App Engine
This is Rietveld 408576698