Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208583004: Remove repaint.js from svg tests that pass without it (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers, pdr., Stephen Chennney
Visibility:
Public.

Description

Remove repaint.js from svg tests that pass without it This set of tests all attempt to do a "repaint" test but aren't about painting at all. If the display() call from repaint.js is removed, these tests all continue to pass, indicating that their output pixels are not affected by the WebTestProxy::displayRepaintMask that covers part of the screen in grey to indicate what has changed. Because of this, it also means that they are not a good candidate for a true text-based repaint rect, as they are either spit out no repaints or full-screen repaints, depending on when paint rect tracking begins. My conclusion is that these tests are really trying to test some incremental layout- or style-related change, and so merely forcing a style/layout recalc, tickling some property, and outputting the final test pixels is a sufficient test. BUG=345027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170134

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove use-instanceRoot-event-bubbling.xhtml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -94 lines) Patch
M LayoutTests/fast/repaint/resources/text-based-repaint.js View 2 chunks +10 lines, -5 lines 0 comments Download
M LayoutTests/svg/as-background-image/animated-svg-as-background.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/as-object/embedded-svg-immediate-offsetWidth-query.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/filter-css-transform-resolution.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/filters/feImage-late-indirect-update.svg View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/foreignObject/fO-parent-display-changes.svg View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/buffered-rendering-dynamic-image.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/buffered-rendering-dynamic-image-expected.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/buffered-rendering-static-image.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/buffered-rendering-static-image-expected.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/repaint/viewport-mask-update.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/absolute-sized-document-scrollbars.svg View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-background-image-tiled.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-background-images.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-clip-path.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-coords-viewattr-01-b.svg View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-css-transforms.svg View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-css-transforms-expected.svg View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-foreign-content.svg View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-foreignObject.svg View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-get-screen-ctm.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-getBoundingClientRect.xhtml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-hixie-mixed-008.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-hixie-mixed-009.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-hixie-rendering-model-004.xhtml View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-mask-with-percentages.svg View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-image.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-object.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-as-relative-image.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-float-border-padding.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/page/zoom-zoom-coords.xhtml View 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/text/zoom-hixie-mixed-008.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/text/zoom-hixie-mixed-009.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/text/zoom-hixie-rendering-model-004.xhtml View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/zoom/text/zoom-svg-float-border-padding.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
enne (OOO)
6 years, 9 months ago (2014-03-21 20:49:53 UTC) #1
jamesr
lgtm sounds reasonable
6 years, 9 months ago (2014-03-25 21:06:02 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-25 21:08:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/208583004/1
6 years, 9 months ago (2014-03-25 21:08:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 21:08:56 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-25 21:08:57 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-25 22:54:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/208583004/70001
6 years, 9 months ago (2014-03-25 22:54:42 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 22:54:57 UTC) #9
commit-bot: I haz the power
Failed to apply patch for LayoutTests/svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-25 22:54:57 UTC) #10
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-25 23:58:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/208583004/70001
6 years, 9 months ago (2014-03-25 23:58:13 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 00:27:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-26 00:27:17 UTC) #14
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 01:18:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/208583004/180001
6 years, 9 months ago (2014-03-27 01:18:56 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 02:21:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 02:21:56 UTC) #18
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 03:58:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/208583004/180001
6 years, 9 months ago (2014-03-27 03:58:29 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 05:01:04 UTC) #21
Message was sent while issue was closed. 
Change committed as 170134

Powered by Google App Engine
This is Rietveld 408576698