Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2085803003: Update the documentation: no longer needs to set clang_use_chrome_plugins (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Update the documentation: no longer needs to set clang_use_chrome_plugins PDFium can be compiled with clang_use_chrome_plugins=true, which is the default setting. So we no longer need to set the variable. BUG=pdfium:469 Committed: https://pdfium.googlesource.com/pdfium/+/bb8b63d6b762393e6e7460351375d596bdabef0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M README.md View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-06-21 18:50:20 UTC) #2
dsinclair
lgtm
4 years, 6 months ago (2016-06-21 18:53:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085803003/1
4 years, 6 months ago (2016-06-21 18:53:51 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 19:23:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bb8b63d6b762393e6e7460351375d596bdab...

Powered by Google App Engine
This is Rietveld 408576698