Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Issue 2085733002: Add a windows_xfa_clang trybot and enable clang_use_chrome_plugins (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add a windows_xfa_clang trybot and enable clang_use_chrome_plugins Add a windows_xfa_clang trybot to capture some errors before committing the code. After we have removed all warnings generated by clang_use_chrome_plugins, enable clang_use_chrome_plugins, which by default is enabled when clang is used. BUG=chromium:619726, pdfium:469 Committed: https://chromium.googlesource.com/chromium/tools/build/+/3bb22ab158e5ff15dbfa296d7940a67db83f9c45

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 17 (8 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-06-20 22:14:41 UTC) #2
Oliver Chang
lgtm
4 years, 6 months ago (2016-06-20 22:18:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085733002/1
4 years, 6 months ago (2016-06-21 15:14:33 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-21 15:14:35 UTC) #7
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-21 16:19:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085733002/1
4 years, 6 months ago (2016-06-21 16:20:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5593)
4 years, 6 months ago (2016-06-21 16:23:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085733002/20001
4 years, 6 months ago (2016-06-21 17:27:16 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 17:31:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/3bb22ab158e5ff15dbfa...

Powered by Google App Engine
This is Rietveld 408576698