Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2085703002: Remove STL use from platform/assert.cc (Closed)

Created:
4 years, 6 months ago by zra
Modified:
4 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add unit tests #

Patch Set 3 : Add parens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M runtime/platform/assert.cc View 1 2 2 chunks +16 lines, -11 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/assert_test.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
Siva, do you know why this was using ostreamstring?
4 years, 6 months ago (2016-06-20 19:44:30 UTC) #2
siva
lgtm. We inherited this code from somewhere else and hence. We did not bother cleaning ...
4 years, 6 months ago (2016-06-21 15:58:26 UTC) #3
zra
https://chromiumcodereview.appspot.com/2085703002/diff/1/runtime/platform/assert.cc File runtime/platform/assert.cc (right): https://chromiumcodereview.appspot.com/2085703002/diff/1/runtime/platform/assert.cc#newcode20 runtime/platform/assert.cc:20: const intptr_t file_offset = (file_len > 1 * KB) ...
4 years, 6 months ago (2016-06-21 19:50:02 UTC) #4
zra
4 years, 6 months ago (2016-06-21 19:50:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fcf4578c0360ede2abed431852aae331ed587435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698