Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 20857003: Fix NaCl OWNERS file. (Closed)

Created:
7 years, 4 months ago by jln (very slow on Chromium)
Modified:
7 years, 4 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Fix NaCl OWNERS file. per-file unfortunately doesn't support subdirectories. See crbug.com/235756. R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/nacl/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
A components/nacl/loader/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Hey Mark! The recent move to components broke this OWNERS file.
7 years, 4 months ago (2013-07-31 21:43:16 UTC) #1
Mark Seaborn
LGTM
7 years, 4 months ago (2013-07-31 21:54:06 UTC) #2
jln (very slow on Chromium)
7 years, 4 months ago (2013-07-31 21:58:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r214826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698