Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 2085683003: Fix string_escaping_test exiting early by re-writing to use async-await. (Closed)

Created:
4 years, 6 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
cbernaschina
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix string_escaping_test exiting early by re-writing to use async-await. Committed: https://github.com/dart-lang/sdk/commit/1f1e425033228274bd32d7b601f8d991ffa5a476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M runtime/observatory/tests/service/string_escaping_test.dart View 1 chunk +38 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 6 months ago (2016-06-21 16:49:30 UTC) #2
cbernaschina
ltgm
4 years, 6 months ago (2016-06-21 21:08:51 UTC) #3
rmacnak
4 years, 6 months ago (2016-06-22 02:19:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f1e425033228274bd32d7b601f8d991ffa5a476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698