chrome/browser/ui/views/tabs/tab.cc - Issue 2085673004: Fix tab strip rendering at non-integral scale factors in MD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 2085673004: Fix tab strip rendering at non-integral scale factors in MD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert some unnecessary stuff Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab.cc

diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc

index 074495d401500b1416437c62f89643fa63176765..84cf80349994372e1de524cdd72405b8eef93913 100644

--- a/chrome/browser/ui/views/tabs/tab.cc

+++ b/chrome/browser/ui/views/tabs/tab.cc

@@ -1656,7 +1656,7 @@ void Tab::ScheduleIconPaint() {

void Tab::GetFillPath(float scale, SkPath* fill) const {

const float right = width() * scale;

- const float bottom = height() * scale;

+ const float bottom = std::ceil(height() * scale);

Peter Kasting 2016/06/21 23:54:10 Add a comment explaining this ceil() call as it's

Bret 2016/06/22 01:00:48 Done.

const float unscaled_endcap_width = GetUnscaledEndcapWidth();

fill->moveTo(right - 1, bottom);

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | no next file » | no next file with comments »