Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: extensions/browser/file_reader.h

Issue 2085673002: Remove calls to MessageLoop::current() in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_FILE_READER_H_ 5 #ifndef EXTENSIONS_BROWSER_FILE_READER_H_
6 #define EXTENSIONS_BROWSER_FILE_READER_H_ 6 #define EXTENSIONS_BROWSER_FILE_READER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/single_thread_task_runner.h"
12 #include "extensions/common/extension_resource.h" 13 #include "extensions/common/extension_resource.h"
13 14
14 namespace base {
15 class MessageLoop;
16 }
17
18 // This file defines an interface for reading a file asynchronously on a 15 // This file defines an interface for reading a file asynchronously on a
19 // background thread. 16 // background thread.
20 // Consider abstracting out a FilePathProvider (ExtensionResource) and moving 17 // Consider abstracting out a FilePathProvider (ExtensionResource) and moving
21 // back to chrome/browser/net if other subsystems want to use it. 18 // back to chrome/browser/net if other subsystems want to use it.
22 class FileReader : public base::RefCountedThreadSafe<FileReader> { 19 class FileReader : public base::RefCountedThreadSafe<FileReader> {
23 public: 20 public:
24 // Reports success or failure and the data of the file upon success. 21 // Reports success or failure and the data of the file upon success.
25 typedef base::Callback<void(bool, const std::string&)> Callback; 22 typedef base::Callback<void(bool, const std::string&)> Callback;
26 23
27 FileReader(const extensions::ExtensionResource& resource, 24 FileReader(const extensions::ExtensionResource& resource,
28 const Callback& callback); 25 const Callback& callback);
29 26
30 // Called to start reading the file on a background thread. Upon completion, 27 // Called to start reading the file on a background thread. Upon completion,
31 // the callback will be notified of the results. 28 // the callback will be notified of the results.
32 void Start(); 29 void Start();
33 30
34 private: 31 private:
35 friend class base::RefCountedThreadSafe<FileReader>; 32 friend class base::RefCountedThreadSafe<FileReader>;
36 33
37 virtual ~FileReader(); 34 virtual ~FileReader();
38 35
39 void ReadFileOnBackgroundThread(); 36 void ReadFileOnBackgroundThread();
40 37
41 extensions::ExtensionResource resource_; 38 extensions::ExtensionResource resource_;
42 Callback callback_; 39 Callback callback_;
43 base::MessageLoop* origin_loop_; 40 const scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_;
44 }; 41 };
45 42
46 #endif // EXTENSIONS_BROWSER_FILE_READER_H_ 43 #endif // EXTENSIONS_BROWSER_FILE_READER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698