Remove calls to MessageLoop::current() in extensions.

Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org

Committed: https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab
Cr-Commit-Position: refs/heads/master@{#402906}

[Reilly Grant (use Gerrit), 2016-06-27 20:01:58]

This patch appears to be doing two things at once. I'm not sure why you are
replacing TestSimpleTaskRunner with TestMockTimeTaskRunner but it looks like
some tests broke in the process.

https://codereview.chromium.org/2085673002/diff/40001/extensions/browser/file...
File extensions/browser/file_reader.h (right):

https://codereview.chromium.org/2085673002/diff/40001/extensions/browser/file...
extensions/browser/file_reader.h:12: #include "base/memory/ref_counted.h"
Duplicate include.

[fdoray, 2016-06-29 14:25:04]

fdoray@chromium.org changed reviewers:
+ caitkp@chromium.org, dewittj@chromium.org

[fdoray, 2016-06-29 14:25:05]

caitkp@: Can you review chrome/browser/safe_browsing/incident_reporting? Thanks.

dewittj@: Can you review chrome/browser/notifications? Thanks.

reillyg@: Can you review extensions/? Thanks. 

In preparation for the migration of browser threads to base/task_scheduler, we
are removing calls to MessageLoop::current(). QuotaService starts a purge timer
if base::MessageLoop::current() != NULL. Replacing this with
ThreadTaskRunnerHandle::IsSet() causes failures in tests that use
TestSimpleTaskRunner because TestSimpleTaskRunner sets a ThreadTaskRunnerHandle
but not a current MessageLoop. Replacing TestSimpleTaskRunner with
TestMockTimeTaskRunner solved some (but not all) test failures.

In the latest patch set, I introduced ScopedDisablePurgeForTesting instead.

https://codereview.chromium.org/2085673002/diff/40001/extensions/browser/file...
File extensions/browser/file_reader.h (right):

https://codereview.chromium.org/2085673002/diff/40001/extensions/browser/file...
extensions/browser/file_reader.h:12: #include "base/memory/ref_counted.h"
On 2016/06/27 20:01:58, Reilly Grant wrote:
> Duplicate include.

Done.

[dewittj, 2016-06-29 16:53:02]

c/b/notifications lgtm

[Reilly Grant (use Gerrit), 2016-06-29 17:07:33]

lgtm

[Cait (Slow), 2016-06-29 18:41:04]

lgtm

[fdoray, 2016-06-29 18:46:42]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-06-29 18:46:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2085673002/#ps80001
(title: "threadtaskrunnerhandle")

[commit-bot: I haz the power, 2016-06-29 18:48:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-06-29 18:53:53]

Description was changed from

==========
Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org
==========

[fdoray, 2016-06-29 18:54:10]

fdoray@chromium.org changed reviewers:
+ achuith@chromium.org

[fdoray, 2016-06-29 18:54:13]

achuith@chromium.org: PTAL to chrome/browser/chromeos

[fdoray, 2016-06-29 18:54:28]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-06-29 18:54:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
reillyg@chromium.org, caitkp@chromium.org, dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2085673002/#ps100001
(title: "fix tests")

[commit-bot: I haz the power, 2016-06-29 18:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 19:46:09]

Description was changed from

==========
Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org
==========

[commit-bot: I haz the power, 2016-06-29 19:46:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-29 19:47:19]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 19:48:51]

Description was changed from

==========
Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org
==========

to

==========
Remove calls to MessageLoop::current() in extensions.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=reillyg@chromium.org
TBR=achuith@chromium.org

Committed: https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab
Cr-Commit-Position: refs/heads/master@{#402906}
==========

[commit-bot: I haz the power, 2016-06-29 19:48:52]

Patchset 6 (id:??) landed as
https://crrev.com/4cfe32abb839f5e2c0a0b7f22ae068e46f1719ab
Cr-Commit-Position: refs/heads/master@{#402906}

[achuithb, 2016-06-30 10:06:29]

lgtm

https://codereview.chromium.org/2085673002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc
(right):

https://codereview.chromium.org/2085673002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc:56:
extensions::QuotaService::ScopedDisablePurgeForTesting
comment would be nice

https://codereview.chromium.org/2085673002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc (right):

https://codereview.chromium.org/2085673002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc:73:
extensions::QuotaService::ScopedDisablePurgeForTesting
ditto