Do not convert mouse wheel gesture events in pepper.

Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974
Committed: https://crrev.com/527139c5692500e9b5587be7226d54f7e8f870b2
Cr-Commit-Position: refs/heads/master@{#400802}

[dtapuska, 2016-06-20 19:05:30]

Description was changed from

==========
Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974
==========

to

==========
Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974
==========

[dtapuska, 2016-06-20 19:05:30]

dtapuska@chromium.org changed reviewers:
+ sadrul@chromium.org

[dtapuska, 2016-06-20 19:06:05]

On 2016/06/20 19:05:30, dtapuska wrote:
> mailto:dtapuska@chromium.org changed reviewers:
> + mailto:sadrul@chromium.org

sadrul@ do you mind taking a quick peak at this change since you originally
wrote this code? Then I will get an OWNER to review it.

Thanks!

[sadrul, 2016-06-20 19:39:39]

yep, lgtm

[dtapuska, 2016-06-20 19:40:53]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org

[dtapuska, 2016-06-20 19:40:53]

creis@chromium.org: Please review changes in

[Charlie Reis, 2016-06-20 21:46:43]

LGTM.  Is this something that could have a regression test added in a followup
CL?  (I won't block this given the need to merge it, but that need also makes it
more important to have test coverage going forward.)

[dtapuska, 2016-06-20 21:53:13]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-06-20 21:53:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085663002/1

[dtapuska, 2016-06-20 21:56:04]

On 2016/06/20 21:46:43, Charlie Reis wrote:
> LGTM.  Is this something that could have a regression test added in a followup
> CL?  (I won't block this given the need to merge it, but that need also makes
it
> more important to have test coverage going forward.)

Ya I considered adding a test; but I didn't find any fullscreen pepper unit
tests. If you know of a location where there are some that I can add a simple
test to I can look into it. But the way it is now adding a unit test for this
seemed to be some work.

[Charlie Reis, 2016-06-20 21:57:29]

creis@chromium.org changed reviewers:
+ alexmos@chromium.org

[Charlie Reis, 2016-06-20 21:58:12]

[+alexmos]

On 2016/06/20 21:56:04, dtapuska wrote:
> On 2016/06/20 21:46:43, Charlie Reis wrote:
> > LGTM.  Is this something that could have a regression test added in a
followup
> > CL?  (I won't block this given the need to merge it, but that need also
makes
> it
> > more important to have test coverage going forward.)
> 
> Ya I considered adding a test; but I didn't find any fullscreen pepper unit
> tests. If you know of a location where there are some that I can add a simple
> test to I can look into it. But the way it is now adding a unit test for this
> seemed to be some work.

Alex, you've worked on some Flash fullscreen issues.  Do you know whether a test
for this issue is feasible to write?

[commit-bot: I haz the power, 2016-06-20 22:00:35]

Description was changed from

==========
Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974
==========

to

==========
Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974
==========

[commit-bot: I haz the power, 2016-06-20 22:00:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-20 22:06:11]

Description was changed from

==========
Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974
==========

to

==========
Do not convert mouse wheel gesture events in pepper.

It appears GesutreScrollBegin and End get translated to mouse events
when in full screen mode.

Do not convert touchpad/mouse wheel gesture events.

BUG=620974

Committed: https://crrev.com/527139c5692500e9b5587be7226d54f7e8f870b2
Cr-Commit-Position: refs/heads/master@{#400802}
==========

[commit-bot: I haz the power, 2016-06-20 22:06:12]

Patchset 1 (id:??) landed as
https://crrev.com/527139c5692500e9b5587be7226d54f7e8f870b2
Cr-Commit-Position: refs/heads/master@{#400802}

[alexmos, 2016-06-20 23:36:32]

On 2016/06/20 21:58:12, Charlie Reis wrote:
> [+alexmos]
> 
> On 2016/06/20 21:56:04, dtapuska wrote:
> > On 2016/06/20 21:46:43, Charlie Reis wrote:
> > > LGTM.  Is this something that could have a regression test added in a
> followup
> > > CL?  (I won't block this given the need to merge it, but that need also
> makes
> > it
> > > more important to have test coverage going forward.)
> > 
> > Ya I considered adding a test; but I didn't find any fullscreen pepper unit
> > tests. If you know of a location where there are some that I can add a
simple
> > test to I can look into it. But the way it is now adding a unit test for
this
> > seemed to be some work.
> 
> Alex, you've worked on some Flash fullscreen issues.  Do you know whether a
test
> for this issue is feasible to write?

I don't know about unit tests, but for browser tests you might try to add a test
to flash_fullscreen_interactive_browsertest.cc, which uses a simulated pepper
plugin
(https://cs.chromium.org/chromium/src/ppapi/tests/test_flash_fullscreen_for_br...)
and runs as part of interactive_ui_tests.  You should be able to synthesize a
mouse wheel event there and see if you get the right events on the other side
(or at least whether the right IPCs get sent).  There's a lot of machinery
involved though, and it might not be very easy.