tests/ImageIsOpaqueTest.cpp - Issue 2085653003: Enable flattening and unflattening of SkColorSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ImageIsOpaqueTest.cpp

Issue 2085653003: Enable flattening and unflattening of SkColorSpace (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ImageIsOpaqueTest.cpp

diff --git a/tests/ImageIsOpaqueTest.cpp b/tests/ImageIsOpaqueTest.cpp

index 42c9f99d38572eee8537988cbf942fc89d747a06..843c1d1aa0fd443950d4d12ef564dbfaf44358f7 100644

--- a/tests/ImageIsOpaqueTest.cpp

+++ b/tests/ImageIsOpaqueTest.cpp

@@ -31,9 +31,7 @@ static void test_flatten(skiatest::Reporter* reporter, const SkImageInfo& info)

info2.unflatten(rb);

REPORTER_ASSERT(reporter, rb.offset() == wb.bytesWritten());

- // FIXME (msarett):

- // Support flatten/unflatten of SkColorSpace objects.

- REPORTER_ASSERT(reporter, info.makeColorSpace(nullptr) == info2.makeColorSpace(nullptr));

+ REPORTER_ASSERT(reporter, info == info2);

}

DEF_TEST(ImageInfo_flattening, reporter) {

« no previous file with comments | « tests/ColorSpaceTest.cpp ('k') | no next file » | no next file with comments »